Skip to content

Conversation

thijsoo
Copy link
Contributor

@thijsoo thijsoo commented Aug 25, 2025

Context

  • We want to make sure the timing is right.

Summary

This PR can be summarized in the following changelog entry:

  • Updates the timing to the correct 2025 timings.

Relevant technical choices:

whoever reviews this make sure the timing is correct for CET in november.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • N/A just make sure that on this pr there is no sudden black friday sale on your site.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@thijsoo thijsoo added this to the feature/bf-2025 milestone Aug 25, 2025
@thijsoo thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Aug 25, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 33f03f37e066b5b2017d6b97a6f2f864fc8a3dbb

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 52.641%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/promotions/domain/black-friday-promotion.php 0 1 0.0%
Totals Coverage Status
Change from base Build ef00ed04e700479cdb503ec095c9722e2ca422b2: -0.5%
Covered Lines: 31039
Relevant Lines: 59388

💛 - Coveralls

Copy link
Member

@pls78 pls78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && Acc: ✅

@pls78 pls78 merged commit 9de9717 into feature/bf-2025 Aug 26, 2025
31 of 32 checks passed
@pls78 pls78 deleted the 752-black-friday-ads-2025---set-timing branch August 26, 2025 08:39
@pls78 pls78 mentioned this pull request Aug 26, 2025
17 tasks
@pls78 pls78 modified the milestones: feature/bf-2025, 25.9 Aug 26, 2025
@enricobattocchi enricobattocchi mentioned this pull request Aug 27, 2025
17 tasks
@enricobattocchi enricobattocchi added this to the 25.9 milestone Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants