-
Notifications
You must be signed in to change notification settings - Fork 935
Add the Black Friday announcement modal #22507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Black Friday announcement modal #22507
Conversation
…make alternating through introductions easier
Pull Request Test Coverage Report for Build e6a7e0b80499bdb8a730b54214937f6933fbef32Details
💛 - Coveralls |
… future and create the new BF one as prioritized
A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch. |
faa1047
to
6e7bafb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acc 👍 two tiny suggestions.
return isWooEnabled ? "yst-woo-introduction-gradient" : "yst-introduction-gradient"; | ||
}, [ isWooEnabled ] ); | ||
|
||
const ctb = useMemo( () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const ctb = useMemo( () => { | |
const ctbId = useMemo( () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed here.
packages/js/src/introductions/components/modals/black-friday-announcement.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR + ACC 👍
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Content
component and make it into separate components for each introduction.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
_yoast_wpseo_introductions
is deleted), without Premium enabled/src/promotions/domain/black-friday-promotion.php
and make sure the bf promotion is active by changing line 16 to:yoa.st/black-friday-modal-ecommerce
when Woo is enabled andyoa.st/black-friday-modal-premium
when Woo is notdata-ctb-id
isc7e7baa1-2020-420c-a427-89701700b607
when Woo is enabled andf6a84663-465f-4cb5-8ba5-f7a6d72224b2
when not._yoast_wpseo_introductions
usermeta and activate Premium/src/promotions/domain/black-friday-promotion.php
code/src/promotions/domain/black-friday-promotion.php
code and confirm that you now will see the BF modal once again./wp-admin/admin.php?page=wpseo_dashboard#/first-time-configuration
)Regression test:
packages\js\src\introductions\initialize.js
, change the"ai-brand-insights-pre-launch": AiBrandInsightsPreLaunch,
line into"google-docs-addon-upsell": GoogleDocsAddonUpsell,
(and addimport { GoogleDocsAddonUpsell } from "./components/modals/google-docs-addon-upsell";
in the imports). Then insrc\introductions\application\ai-brand-insights-pre-launch.php
return false in the should_show() function and insrc\introductions\application\google-docs-addon-upsell.php
returnreturn $this->current_page_helper->is_yoast_seo_page()
in that same function.Relevant test scenarios
Test instructions for QA when the code is in the RC
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes #