Feature/#23 login #28

ashwon12 · 2025-01-23T06:53:39Z

💡 Issue

Resolved: [Feature] 로그인 뷰 #23

🌱 Key changes

로그인 스크린 생성
뷰모델 생성
state , intent, effect 생성

✅ To Reviewers

screen 단위로 고려해서 state 선언했습니다 !

UI 상태 관련 추가 수정

sealed class로 하나의 State를 만들고 구현 vs
하나의 State data class로 관리하기

( data class 로 개발 )

sealed class경우 state별로 중복된 값이 많아질 수 있음
mvistore 내부에서 copy를 통해 state 업데이트되도록 되어있음 ( 이미 data class처럼 구현 )

내용 정리

📸 스크린샷

로그인

Summary by CodeRabbit

새로운 기능
- 로그인 화면의 사용자 인터페이스 개선
- 로그인 및 회원가입 입력 섹션 추가
- 로그인 상태 및 인텐트 관리를 위한 새로운 아키텍처 도입
버그 수정
- 로그인 화면의 구조적 개선을 통한 잠재적 버그 해결
UI 변경
- 새로운 로그인 화면 디자인 적용
- 로그인 일러스트레이션 추가
- 입력 필드 및 버튼 스타일 업데이트
종속성 업데이트
- Hilt 네비게이션 컴포즈 라이브러리 추가
- 앱 컴포넌트 의존성 관리 개선

coderabbitai · 2025-01-23T06:53:47Z

Walkthrough

이 풀 리퀘스트는 로그인 기능의 새로운 구현을 소개합니다. 프로젝트에 Hilt 종속성 주입을 통합하고, 로그인 화면의 구조를 개선하며, 상태 관리를 위한 새로운 아키텍처를 도입했습니다. 주요 변경 사항은 LoginViewModel, LoginState, LoginScreen 등의 새로운 컴포넌트 추가와 기존 네비게이션 로직의 업데이트를 포함합니다.

Changes

파일	변경 요약
`app/src/main/java/com/yapp/app/official/navigation/YappNavHost.kt`	파라미터 이름 변경: `onSignUpClick` → `onClickSignUp`
`build-logic/src/main/java/com/yapp/HiltAndroid.kt`	Hilt 네비게이션 컴포즈 의존성 추가
`core/ui/build.gradle.kts`	`androidx.appcompat` 의존성 제거
`feature/login/build.gradle.kts`	Hilt 플러그인 추가
`feature/login/src/main/java/com/yapp/feature/login/*`	로그인 관련 새로운 컴포넌트 및 기능 추가
`gradle/libs.versions.toml`	Hilt 네비게이션 컴포즈 버전 참조 추가

Assessment against linked issues

목표	해결 여부	설명
로그인 뷰 구현 [#23]	✅

Possibly related PRs

Feature/#26 navigation #27: 로그인 네비게이션 그래프 파라미터 이름 변경과 관련

Suggested labels

CodeRabbit

Suggested reviewers

jinukeu

Poem

🐰 로그인의 문을 열며
코드의 토끼 깡총깡총
상태와 뷰가 춤을 추네
Hilt의 마법으로 빛나는 길
새로운 기능 반짝반짝! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

feature/login/src/main/java/com/yapp/feature/login/LoginScreen.kt

feature/login/src/main/java/com/yapp/feature/login/component/HorizontalDivider.kt

feature/login/src/main/java/com/yapp/feature/login/LoginViewModel.kt

feature/login/src/main/java/com/yapp/feature/login/LoginScreen.kt

feature/login/src/main/java/com/yapp/feature/login/LoginState.kt

app/src/main/java/com/yapp/app/official/navigation/YappNavHost.kt

ashwon12 · 2025-01-24T06:19:22Z

@jinukeu
진욱님 state 정의를 다시 해야할 것 같아서 수정 머지 완료하고 재요청 드리겠습니다 !!!!

feature/login/src/main/java/com/yapp/feature/login/component/HorizontalDivider.kt

feature/login/src/main/java/com/yapp/feature/login/LoginScreen.kt

feature/login/src/main/java/com/yapp/feature/login/component/HorizontalDivider.kt

feature/login/src/main/java/com/yapp/feature/login/component/TopTitle.kt

ashwon12 · 2025-01-24T18:51:03Z

@jinukeu 리뷰 재요청 드립니당

jinukeu

네이밍 부분은 같이 맞춰보면 좋을 것 같네요~!

jinukeu · 2025-01-25T01:32:03Z

app/src/main/java/com/yapp/app/official/navigation/YappNavHost.kt

@@ -21,7 +21,7 @@ fun YappNavHost(
        modifier = modifier,
    ) {
        loginNavGraph(
-            signupDestination = { navigator.navigateSignUpScreen() }
+            onClickSignUp = { navigator.navigateSignUpScreen() }


A: navigateToSignUp 네이밍이 더 좋을거같아요

jinukeu · 2025-01-25T01:32:54Z

feature/login/src/main/java/com/yapp/feature/login/LoginScreen.kt

-            is LoginSideEffect.ShowToast -> {
-                Toast.makeText(context, effect.message, Toast.LENGTH_SHORT).show()
-            }
+            is LoginSideEffect.ShowSignUpDialog -> {}


A: ShowSignUpDialog는 SideEffect보다는 State로 관리하는게 좋을거에요 (다음 PR에서 한번 해보시죠)

feature/login/src/main/java/com/yapp/feature/login/LoginScreen.kt

feature/login/src/main/java/com/yapp/feature/login/component/LoginInputSection.kt

feature/login/src/main/java/com/yapp/feature/login/component/LoginSignUpSection.kt

feature/login/src/main/res/values/strings.xml

feature/login/src/main/java/com/yapp/feature/login/component/LoginInputSection.kt

feature/login/src/main/java/com/yapp/feature/login/component/LoginDivider.kt

ashwon12 · 2025-01-25T05:15:18Z

@coderabbitai review

coderabbitai · 2025-01-25T05:15:24Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai

Actionable comments posted: 21

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 81ab12d and 409f40a.

📒 Files selected for processing (15)

app/src/main/java/com/yapp/app/official/navigation/YappNavHost.kt (1 hunks)
build-logic/src/main/java/com/yapp/HiltAndroid.kt (1 hunks)
core/ui/build.gradle.kts (0 hunks)
feature/login/build.gradle.kts (1 hunks)
feature/login/src/main/java/com/yapp/feature/login/LoginScreen.kt (1 hunks)
feature/login/src/main/java/com/yapp/feature/login/LoginState.kt (1 hunks)
feature/login/src/main/java/com/yapp/feature/login/LoginViewModel.kt (1 hunks)
feature/login/src/main/java/com/yapp/feature/login/component/LoginDivider.kt (1 hunks)
feature/login/src/main/java/com/yapp/feature/login/component/LoginInputSection.kt (1 hunks)
feature/login/src/main/java/com/yapp/feature/login/component/LoginSignUpSection.kt (1 hunks)
feature/login/src/main/java/com/yapp/feature/login/component/TopTitle.kt (1 hunks)
feature/login/src/main/java/com/yapp/feature/login/navigation/LoginNavigation.kt (1 hunks)
feature/login/src/main/res/drawable/illust_login_yappu.xml (1 hunks)
feature/login/src/main/res/values/strings.xml (1 hunks)
gradle/libs.versions.toml (2 hunks)

💤 Files with no reviewable changes (1)

core/ui/build.gradle.kts

🔇 Additional comments (8)

feature/login/src/main/res/drawable/illust_login_yappu.xml (1)

1-95: 전반적인 벡터 드로어블 구현이 잘 되어있습니다.

복잡한 일러스트레이션을 벡터 드로어블로 잘 구현하였습니다. 다만, 위에서 언급한 최적화 사항들을 고려하여 개선하면 더 좋을 것 같습니다.

build-logic/src/main/java/com/yapp/HiltAndroid.kt (1)

16-16: Hilt Navigation Compose 의존성 추가가 적절합니다.

로그인 기능의 네비게이션 요구사항을 위해 필요한 의존성이 잘 추가되었습니다.
feature/login/src/main/java/com/yapp/feature/login/LoginState.kt (2)

4-12: 🛠️ Refactor suggestion

상태 클래스의 일관성 있는 네이밍이 필요합니다.

네이밍 일관성 개선:

pwFailDescription → passwordFailDescription

isPWVisible → isPasswordVisible

isActivateLoginButton → isLoginButtonEnabled

기본 컴포넌트의 네이밍 규칙을 따르기 위해:

failDescription → errorDescription
 data class LoginState(
     val id: String = "",
     val password: String = "",
-    val idFailDescription : String? = null,
-    val pwFailDescription : String? = null,
-    val isPWVisible: Boolean = false,
+    val idErrorDescription: String? = null,
+    val passwordErrorDescription: String? = null,
+    val isPasswordVisible: Boolean = false,
 ){
-    val isActivateLoginButton : Boolean = id.isNotEmpty() && password.isNotEmpty()
+    val isLoginButtonEnabled: Boolean = id.isNotEmpty() && password.isNotEmpty()
 }
Likely invalid or redundant comment.

14-19: 🛠️ Refactor suggestion

LoginIntent 클래스의 일관성 개선이 필요합니다.

네이밍 일관성:

InputPW → InputPassword

포맷팅 일관성:

괄호 주변 공백 제거 필요
 sealed interface LoginIntent {
-    data class InputID (val id : String) : LoginIntent
-    data class InputPW ( val pw : String ) : LoginIntent
+    data class InputId(val id: String) : LoginIntent
+    data class InputPassword(val password: String) : LoginIntent
     data object ClickLoginButton : LoginIntent
     data object ClickSignUpButton : LoginIntent
 }
Likely invalid or redundant comment.
app/src/main/java/com/yapp/app/official/navigation/YappNavHost.kt (1)

24-24: 🧹 Nitpick (assertive)

네비게이션 함수 네이밍 개선이 필요합니다.

이전 리뷰 피드백에 따라 동작을 더 명확하게 나타내는 네이밍으로 변경하는 것이 좋겠습니다:

navigateSignUpScreen → navigateToSignUp
-            onClickSignUp = { navigator.navigateSignUpScreen() }
+            onClickSignUp = { navigator.navigateToSignUp() }
Likely invalid or redundant comment.
feature/login/src/main/java/com/yapp/feature/login/component/LoginInputSection.kt (1)

49-62: 🧹 Nitpick (assertive)

Preview 함수를 개선할 수 있습니다.

프리뷰 함수에 다음 개선사항을 적용하면 좋겠습니다:

불필요한 Column 제거

의미 있는 테스트 데이터 사용

다양한 상태 테스트 (활성/비활성 등)
@Preview(showBackground = true)
@Composable
private fun LoginScreenPreview() {
    YappTheme {
-       Column {
            LoginInputSection(
-               "",
-               "",
+               email = "[email protected]",
+               password = "password123",
                onIDChange = {},
                onPWChange = {},
-               false,
+               isActive = true,
-               {}
+               onLoginClick = {}
            )
-       }
    }
}
Likely invalid or redundant comment.
feature/login/build.gradle.kts (1)

5-5: Hilt 플러그인 추가가 적절합니다.

의존성 주입을 위한 Hilt 플러그인이 올바르게 추가되었습니다.

gradle/libs.versions.toml (1)

20-21: Hilt Navigation Compose 의존성이 적절하게 추가되었습니다.

버전과 라이브러리 설정이 올바르게 구성되어 있습니다.

Also applies to: 55-56

feature/login/src/main/java/com/yapp/feature/login/component/TopTitle.kt

coderabbitai · 2025-01-25T05:18:05Z

feature/login/src/main/java/com/yapp/feature/login/component/TopTitle.kt

+@Preview(showBackground = true)
+@Composable
+private fun LoginScreenPreview() {
+    YappTheme {
+        TopTitle()
+    }
+}


🧹 Nitpick (assertive)

프리뷰 기능을 더욱 개선해보세요.

프리뷰가 잘 구현되어 있습니다만, 다양한 디바이스 설정과 테마에서의 모습을 확인할 수 있도록 개선하면 좋을 것 같습니다.

다음과 같이 수정해보세요:

@Preview(showBackground = true) +@Preview(showBackground = true, uiMode = Configuration.UI_MODE_NIGHT_YES) +@Preview(showBackground = true, device = Devices.TABLET) @Composable private fun LoginScreenPreview() { YappTheme { TopTitle() } }

필요한 import문도 추가해주세요:

import android.content.res.Configuration import androidx.compose.ui.tooling.preview.Devices

feature/login/src/main/java/com/yapp/feature/login/component/TopTitle.kt

feature/login/src/main/res/drawable/illust_login_yappu.xml

coderabbitai · 2025-01-25T05:18:06Z

feature/login/src/main/java/com/yapp/feature/login/component/LoginInputSection.kt

+    id : String,
+    pw : String,
+    onIDChange: (String) -> Unit,
+    onPWChange: (String) -> Unit,
+    isActive : Boolean,
+    clickButton : () -> Unit


🧹 Nitpick (assertive)

파라미터 네이밍을 일관성 있게 수정해주세요.

현재 파라미터 네이밍이 일관성이 없습니다:

id, pw는 더 명확한 이름이 좋습니다

clickButton은 다른 콜백 네이밍과 일치시키는 것이 좋습니다

- id : String, - pw : String, + email: String, + password: String, onIDChange: (String) -> Unit, onPWChange: (String) -> Unit, isActive : Boolean, - clickButton : () -> Unit + onLoginClick: () -> Unit

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

id : String,

pw : String,

onIDChange: (String) -> Unit,

onPWChange: (String) -> Unit,

isActive : Boolean,

clickButton : () -> Unit

email: String,

password: String,

onIDChange: (String) -> Unit,

onPWChange: (String) -> Unit,

isActive : Boolean,

onLoginClick: () -> Unit

coderabbitai · 2025-01-25T05:18:06Z

feature/login/src/main/java/com/yapp/feature/login/LoginScreen.kt

+    onPWChange : (String) -> Unit,
+) {
+    Column {
+        Spacer(Modifier.height(72.dp))


🧹 Nitpick (assertive)

하드코딩된 dimension 값들을 리소스로 추출하는 것이 좋습니다.

여러 곳에서 사용되는 spacing 값들(72.dp, 24.dp, 32.dp)을 dimens.xml 파일로 추출하여 재사용성을 높이고 일관성을 유지하는 것이 좋습니다.

Also applies to: 77-77, 79-79

coderabbitai · 2025-01-25T05:18:06Z

feature/login/src/main/java/com/yapp/feature/login/LoginScreen.kt

+internal fun LoginRouteScreen(
+    onClickSignUP: (String) -> Unit,
+    modifier: Modifier = Modifier,
+    viewModel: LoginViewModel = hiltViewModel()
+) {


🧹 Nitpick (assertive)

파라미터 네이밍 일관성 개선이 필요합니다.

onClickSignUP의 'UP' 부분이 일반적인 네이밍 컨벤션과 맞지 않습니다. onClickSignUp으로 수정하는 것이 좋겠습니다.

- onClickSignUP: (String) -> Unit, + onClickSignUp: (String) -> Unit,

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

internal fun LoginRouteScreen(

onClickSignUP: (String) -> Unit,

modifier: Modifier = Modifier,

viewModel: LoginViewModel = hiltViewModel()

) {

internal fun LoginRouteScreen(

onClickSignUp: (String) -> Unit,

modifier: Modifier = Modifier,

viewModel: LoginViewModel = hiltViewModel()

) {

feature/login/src/main/java/com/yapp/feature/login/LoginScreen.kt

feature/login/src/main/res/values/strings.xml

ashwon12 added 4 commits January 23, 2025 15:49

feat/#23 : 네이밍 수정

1e5ec0c

feat/#23 : state , intent, effect 선언

62bb185

feat/#23 : 뷰모델 설정

e1686dc

feat/#23 : 로그인 화면

6ebfc6c

ashwon12 added Feature 기능 추가, 개발 Design UI 및 디자인 관련 작업 labels Jan 23, 2025

ashwon12 requested a review from jinukeu January 23, 2025 06:53

ashwon12 self-assigned this Jan 23, 2025

jinukeu requested changes Jan 23, 2025

View reviewed changes

feat/#23 : 불필요한 코드 제거

87d0522

jinukeu reviewed Jan 24, 2025

View reviewed changes

ashwon12 added 4 commits January 25, 2025 03:48

gradle/#23 : hilt-navigation-comose 추가

9de86d4

feat/#23 : component 분리 및 프리뷰 생성

3a3ca91

feat/#23 : state 재정의

320d068

refactor/#23 : 변수 변경 및 string 리소스 관리

409f40a

ashwon12 requested a review from jinukeu January 24, 2025 18:50

jinukeu approved these changes Jan 25, 2025

View reviewed changes

coderabbitai bot reviewed Jan 25, 2025

View reviewed changes

ashwon12 merged commit 096e60f into develop Jan 25, 2025
1 check passed

ashwon12 deleted the feature/#23-login branch January 28, 2025 15:15

This was referenced Jan 28, 2025

Feature/#29 서비스 이용약관 팝업 기능 #49

Merged

Feature/#59 설정화면 Route, Contract, ViewModel / AlertDialog #70

Merged

coderabbitai bot mentioned this pull request Feb 18, 2025

Feature/#78 login #83

Merged

Feature/#23 login #28

Feature/#23 login #28

Uh oh!

Conversation

ashwon12 commented Jan 23, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💡 Issue

🌱 Key changes

✅ To Reviewers

📸 스크린샷

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ashwon12 commented Jan 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ashwon12 commented Jan 24, 2025

Uh oh!

jinukeu left a comment

Choose a reason for hiding this comment

Uh oh!

jinukeu Jan 25, 2025

Choose a reason for hiding this comment

Uh oh!

jinukeu Jan 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ashwon12 commented Jan 25, 2025

Uh oh!

coderabbitai bot commented Jan 25, 2025

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot Jan 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot Jan 25, 2025

Choose a reason for hiding this comment

Uh oh!

ashwon12 commented Jan 23, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 23, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)