[Feature] 홈 화면 최근 출석내역 #201

DongChyeon · 2025-05-24T15:09:15Z

💡 Issue

Resolved: [Feature] 홈 화면 최근 출석내역 #200

🌱 Key changes

홈 헤더 세션 아이템 width 변경 (좌우 44.dp의 패딩을 가지도록)
최근 출석 현황 구현

✅ To Reviewers

현재 홈 화면 Pull To Refresh 시에 임박한 세션의 출석 버튼의 갱신을 위해 해당 부분만 API 재호출 중인데
최근 출석 현황도 업데이트 수단이 필요할지... 고민되네요

📸 스크린샷

스크린샷

Summary by CodeRabbit

신규 기능
- 홈 화면에 최근 출석 현황을 표시하는 UI가 추가되었습니다.
- 최근 출석 현황에서 '전체 보기' 버튼을 통해 출석 내역 전체 화면으로 이동할 수 있습니다.
개선 사항
- 출석 내역 데이터에 이름 정보가 추가되어, 최근 출석 현황에 이름이 함께 표시됩니다.
- 세션 아이템의 너비가 기기 화면에 맞게 동적으로 조정됩니다.
문서 및 리소스
- 최근 출석 현황 및 전체 보기 관련 신규 문자열 리소스가 추가되었습니다.
기타
- 일부 네비게이션 함수의 이름이 더 간결하게 변경되었습니다.

coderabbitai · 2025-05-24T15:09:22Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

CodeRabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

최근 출석 내역을 홈 화면에 표시하고, 전체 출석 내역 화면으로 이동하는 네비게이션을 추가하는 기능이 도입되었습니다. 관련 데이터 모델, UI, ViewModel, 네비게이션 및 문자열 리소스가 확장 및 수정되었습니다. 네비게이션 함수 네이밍도 일관성 있게 변경되었습니다.

Changes

파일/경로 요약	변경 내용 요약
.../YappNavHost.kt, .../Navigator.kt, .../HomeNavigation.kt	출석 내역 화면으로 이동하는 네비게이션 액션 및 콜백 추가, 네비게이션 함수 네이밍 일관성 있게 변경
.../AttendanceHistoryListResponse.kt, .../AttendanceHistory.kt	AttendanceHistory 모델에 name 필드 추가 및 데이터 변환 함수 수정
.../HomeContract.kt, .../HomeViewModel.kt	HomeState에 최근 출석 내역 상태 추가, 관련 Intent/SideEffect/Intent 처리 및 데이터 로딩 로직 구현
.../HomeScreen.kt, .../HomeRecentAttendanceHistory.kt	최근 출석 내역 UI 컴포넌트 추가, 전체 보기 클릭 이벤트 및 콜백 연결, UI 문자열 리소스 적용
.../HomeHeader.kt	SessionItem의 width를 화면 크기에 맞게 동적으로 조정, 프리뷰에 YappTheme 적용
.../strings.xml	최근 출석 현황 및 전체 보기 관련 문자열 리소스 추가
.../SettingNavigation.kt	SettingRoute import 및 호출 방식 단순화

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant HomeScreen
    participant HomeViewModel
    participant AttendanceRepository
    participant Navigator

    User->>HomeScreen: 홈 진입
    HomeScreen->>HomeViewModel: HomeIntent.EnterHomeScreen
    HomeViewModel->>AttendanceRepository: 출석 내역 조회
    AttendanceRepository-->>HomeViewModel: AttendanceHistoryList 반환
    HomeViewModel->>HomeScreen: 최근 출석 내역 상태 업데이트

    User->>HomeScreen: "전체 보기" 클릭
    HomeScreen->>HomeViewModel: HomeIntent.ClickShowAllAttendanceHistory
    HomeViewModel->>HomeScreen: HomeSideEffect.NavigateToAttendanceHistory
    HomeScreen->>Navigator: navigateAttendanceHistory()

Assessment against linked issues

Objective	Addressed	Explanation
홈 화면 최근 출석내역 표시 및 전체 출석내역 네비게이션 (#200)	✅

Possibly related PRs

Feature/#69 homeview #77: 네비게이션 함수 및 그래프 구조 변경 관련, 네비게이션 컴포넌트와 직접적 코드 레벨 연관성.
Feature/#26 navigation #27: NavigatorState 및 YappNavHost의 네비게이션 함수 구조와 직접적으로 연관.
Feature/#155 출석 내역 화면 세션 출석 내역 표시 #162: 출석 내역 데이터/모델/리포지토리/상세 UI 등 인프라 구축, 본 PR은 해당 기능 활용 및 연계.

Suggested labels

Design

Suggested reviewers

jinukeu

Poem

🐰
홈 화면에 출석 내역이 쏙,
토끼도 출석 체크를 톡톡!
전체 보기 버튼을 꾹 눌러
출석의 역사를 한눈에 봐요.
네비게이션도 이름이 쏙쏙,
오늘도 코드밭에 당근 한 줌 쏙!
🥕

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

DongChyeon · 2025-05-24T15:10:19Z

@coderabbitai review

coderabbitai · 2025-05-24T15:10:24Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

jinukeu · 2025-05-24T15:13:41Z

feature/home/src/main/java/com/yapp/feature/home/HomeViewModel.kt

+        }.onFailure { e ->
+            when (e) {
+                is InvalidTokenException -> postSideEffect(HomeSideEffect.NavigateToLogin)
+                else -> e.record()


R: postSideEffect(HomeSideEffect.HandleException(it)) 을 통해 문제가 발생했음을 유저에게 알려주세요!

현재 예정된 세션이 없는 상태라 API 호출할 때마다 해당 오류가 발생하는 상황이라...
NoScheduleSeesionException에만 handleException(it) 하지 않도록 할까요??

NoScheduleSeesionException에만 handleException(it) 하지 않도록 할까요??
-> 넵! 요렇게 처리 부탁드릴게요!

요거랑 출석 현황 새로고침 처리했어요

feature/home/src/main/java/com/yapp/feature/home/component/HomeHeader.kt

jinukeu · 2025-05-24T15:15:30Z

Pull To Refresh할 때 최근 출석 현황도 업데이트되면 좋을거같아요!

jinukeu

확인했습니다
고생하셨어요!

feature/home/src/main/java/com/yapp/feature/home/HomeViewModel.kt

DongChyeon requested review from TaeseongYun, ashwon12 and jinukeu May 24, 2025 15:09

DongChyeon self-assigned this May 24, 2025

DongChyeon added the Feature 기능 추가, 개발 label May 24, 2025

jinukeu requested changes May 24, 2025

View reviewed changes

DongChyeon requested a review from jinukeu May 24, 2025 16:19

jinukeu approved these changes May 24, 2025

View reviewed changes

feature/home/src/main/java/com/yapp/feature/home/HomeViewModel.kt Show resolved Hide resolved

DongChyeon added 6 commits May 25, 2025 01:28

feat/#200: AttendanceHistory 도메인 모델에 name 추가

516b10b

feat/#200: HomeRecentAttendanceHistory 컴포넌트 구현

133e773

feat/#200: 출석 정보 API 연동

bbf16c3

fix/#200: SessionItem width 변경

863979c

feat/#200: Pull To Refresh 시 최근 출석 현황 갱신

254872e

refactor/#200: NoScheduledSessionException에 대한 예외 분기를 명시적으로 분리

4bc3c72

DongChyeon force-pushed the feature/#200-home-recent-attendance branch from 19b2431 to 4bc3c72 Compare May 24, 2025 16:28

chore: 1.1.1 (7) 버전 코드 변경

8033124

DongChyeon merged commit c494dc4 into develop May 24, 2025
4 checks passed

DongChyeon deleted the feature/#200-home-recent-attendance branch May 24, 2025 16:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Feature] 홈 화면 최근 출석내역 #201

[Feature] 홈 화면 최근 출석내역 #201

Uh oh!

DongChyeon commented May 24, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented May 24, 2025 •

edited

Loading

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

DongChyeon commented May 24, 2025

Uh oh!

coderabbitai bot commented May 24, 2025

Uh oh!

jinukeu May 24, 2025

Uh oh!

DongChyeon May 24, 2025

Uh oh!

jinukeu May 24, 2025

Uh oh!

DongChyeon May 24, 2025

Uh oh!

Uh oh!

jinukeu commented May 24, 2025

Uh oh!

jinukeu left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

[Feature] 홈 화면 최근 출석내역 #201

[Feature] 홈 화면 최근 출석내역 #201

Uh oh!

Conversation

DongChyeon commented May 24, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💡 Issue

🌱 Key changes

✅ To Reviewers

📸 스크린샷

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented May 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Sequence Diagram(s)

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

DongChyeon commented May 24, 2025

Uh oh!

coderabbitai bot commented May 24, 2025

Uh oh!

jinukeu May 24, 2025

Choose a reason for hiding this comment

Uh oh!

DongChyeon May 24, 2025

Choose a reason for hiding this comment

Uh oh!

jinukeu May 24, 2025

Choose a reason for hiding this comment

Uh oh!

DongChyeon May 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jinukeu commented May 24, 2025

Uh oh!

jinukeu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DongChyeon commented May 24, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 24, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)