feat/#189: 가입 신청 시 버튼 비활성화 처리

[jinukeu]

💡 Issue

• Resolved: [Bug] 회원가입 시, 회원 가입 버튼 Disabled 처리 #189

🌱 Key changes

• 가입 신청 버튼 클릭 시 중복 클릭을 방지하기 위해 버튼을 비활성화 처리합니다.

✅ To Reviewers

📸 스크린샷

KakaoTalk_Video_2025-05-10-00-38-02.mp4

Summary by CodeRabbit

• 신규 기능
  • 회원가입 요청 중일 때 버튼 활성화 상태가 변경되어, "회원가입 코드 없음" 버튼과 "입력 완료" 버튼이 요청 진행 중에는 비활성화됩니다.
• 버그 수정
  • 회원가입 요청이 진행 중일 때 중복 요청을 방지하기 위해 관련 버튼들이 비활성화됩니다.

[coderabbitai]

Walkthrough

회원가입 화면에서 회원가입 요청이 진행 중일 때 버튼 활성화 상태를 제어하는 로직이 추가 및 수정되었습니다. 버튼 활성화는 이제 내부 상태 값(isSignUpRequesting)에 따라 동적으로 변경됩니다. 관련 UI 컴포넌트와 ViewModel, 상태 데이터 클래스가 이에 맞게 수정되었습니다.

Changes

파일/경로	변경 요약
.../signup/SignUpContract.kt	SignUpState에 isSignUpRequesting(private), noSignUpCodeButtonEnable(public) 속성 추가 및 버튼 활성화 조건 수정
.../signup/SignUpViewModel.kt	signUp 함수에서 회원가입 요청 전후로 isSignUpRequesting 상태를 true/false로 변경하는 로직 추가
.../signup/component/SignUpCodeBottomDialog.kt	SignUpCodeBottomDialog 함수에 noSignUpCodeButtonEnable 파라미터 추가 및 버튼 활성화에 적용
.../signup/SignUpScreen.kt	SignUpCodeBottomDialog 호출 시 noSignUpCodeButtonEnable 파라미터 전달 추가

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SignUpScreen
    participant SignUpViewModel
    participant SignUpState

    User->>SignUpScreen: 회원가입 버튼 클릭
    SignUpScreen->>SignUpViewModel: signUp() 호출
    SignUpViewModel->>SignUpState: isSignUpRequesting = true
    SignUpViewModel->>SignUp UseCase: 회원가입 요청
    SignUp UseCase-->>SignUpViewModel: 결과 반환
    SignUpViewModel->>SignUpState: isSignUpRequesting = false
    SignUpState-->>SignUpScreen: 버튼 활성화 상태 갱신

Loading

Assessment against linked issues

Objective	Addressed	Explanation
회원가입 요청 시, 회원가입 버튼이 Disabled 처리되어야 한다 (#189)	✅

Suggested labels

Feature

Poem

🐇
버튼이 깜빡, 요청 중엔 잠깐
토끼가 말해요, "기다려, 곧 끝나!"
비활성화된 버튼 아래
회원가입이 더 안전해
코드를 바꾼 오늘 밤,
토끼는 춤추며 박수 짝짝!
🌱

Tip

⚡️ Faster reviews with caching

• CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ab33cb6 and 29a4ca8.

📒 Files selected for processing (4)

• feature/signup/src/main/java/com/yapp/feature/signup/signup/SignUpContract.kt (1 hunks)
• feature/signup/src/main/java/com/yapp/feature/signup/signup/SignUpScreen.kt (1 hunks)
• feature/signup/src/main/java/com/yapp/feature/signup/signup/SignUpViewModel.kt (2 hunks)
• feature/signup/src/main/java/com/yapp/feature/signup/signup/component/SignUpCodeBottomDialog.kt (2 hunks)

🔇 Additional comments (7)

feature/signup/src/main/java/com/yapp/feature/signup/signup/SignUpContract.kt (2)

14-14: 상태 추적을 위한 적절한 플래그 추가.

isSignUpRequesting 플래그를 추가하여 회원가입 요청 진행 상태를 추적할 수 있게 되었습니다. 이는 중복 클릭을 방지하기 위한 좋은 접근 방식입니다.

---

18-19: 버튼 활성화 상태 제어 로직 개선.

회원가입 요청 중에는 버튼들이 비활성화되도록 하는 로직이 적절하게 구현되었습니다. 이것은 중복 가입 요청을 효과적으로 방지합니다.

feature/signup/src/main/java/com/yapp/feature/signup/signup/SignUpViewModel.kt (2)

213-213: 회원가입 요청 시작 시 상태 업데이트 적용.

회원가입 요청이 시작될 때 isSignUpRequesting을 true로 설정하여 버튼 비활성화 처리를 적절히 시작합니다.

---

240-240: 회원가입 요청 완료 후 상태 복원.

요청 성공 또는 실패와 상관없이 isSignUpRequesting을 false로 재설정하여 버튼을 다시 활성화하는 로직이 잘 구현되었습니다.

feature/signup/src/main/java/com/yapp/feature/signup/signup/component/SignUpCodeBottomDialog.kt (2)

26-26: 다이얼로그 컴포넌트에 버튼 활성화 상태 파라미터 추가.

코드 입력 불필요 버튼의 활성화 상태를 제어하기 위한 파라미터가 추가되었습니다. 컴포넌트 API가 적절하게 확장되었습니다.

---

68-68: 버튼 활성화 상태 연결.

추가된 noSignUpCodeButtonEnable 파라미터를 버튼의 enable 속성에 연결하여 회원가입 요청 중에 버튼이 비활성화되도록 구현되었습니다.

feature/signup/src/main/java/com/yapp/feature/signup/signup/SignUpScreen.kt (1)

179-179: 다이얼로그에 버튼 활성화 상태 전달.

uiState로부터 noSignUpCodeButtonEnable 속성을 SignUpCodeBottomDialog 컴포넌트로 전달하여 버튼 활성화 상태가 제대로 연결되었습니다. 이 변경으로 회원가입 요청 중 중복 클릭을 방지하는 목표가 달성되었습니다.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[jinukeu]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[DongChyeon]

확인했습니다