Feature/#15 designsystem button text #16

jinukeu · 2025-01-14T15:45:21Z

💡 Issue

Resolved: [Feature] Design System ButtonText #15

🌱 Key changes

DesignSystem - Button Text / Primary, Assistive 구현했습니다.

✅ To Reviewers

📸 스크린샷

스크린샷

Summary by CodeRabbit

새로운 기능
- 디자인 시스템에 텍스트 버튼 컴포넌트 추가
- 다양한 크기와 스타일의 버튼 지원 (Medium, Small)
- 버튼 상태에 따른 색상 및 상호작용 구현
스타일 변경
- label1NormalBold 텍스트 스타일의 글꼴 굵기 조정 (700 → 600)
디자인 시스템 개선
- 버튼 기본값 및 색상 구성 표준화
- 재사용 가능한 버튼 컴포넌트 개발

coderabbitai · 2025-01-14T15:45:29Z

워크스루

이 풀 리퀘스트는 Yapp 디자인 시스템의 텍스트 버튼 컴포넌트를 확장하고 개선합니다. 새로운 파일들(TextAssistiveButton.kt, TextButtonBasic.kt, TextButtonDefaults.kt, TextPrimaryButton.kt)이 추가되어 다양한 크기와 스타일의 텍스트 버튼을 지원합니다. 또한 Typography.kt에서 label1NormalBold 텍스트 스타일의 폰트 두께가 약간 조정되었습니다.

변경 사항

파일	변경 요약
`core/designsystem/src/main/java/com/yapp/core/designsystem/component/button/text/TextAssistiveButton.kt`	보조 텍스트 버튼 (중간, 작은 크기) 컴포넌트 추가
`core/designsystem/src/main/java/com/yapp/core/designsystem/component/button/text/TextButtonBasic.kt`	기본 텍스트 버튼 컴포넌트 구현
`core/designsystem/src/main/java/com/yapp/core/designsystem/component/button/text/TextButtonDefaults.kt`	텍스트 버튼 기본값 및 색상 설정 추가
`core/designsystem/src/main/java/com/yapp/core/designsystem/component/button/text/TextPrimaryButton.kt`	기본 텍스트 버튼 (중간, 작은 크기) 컴포넌트 추가
`core/designsystem/src/main/java/com/yapp/core/designsystem/theme/Typography.kt`	`label1NormalBold` 폰트 두께 600으로 변경

연결된 이슈에 대한 평가

목표	해결 여부	설명
디자인 시스템 버튼 텍스트 컴포넌트 구현	✅
다양한 크기의 버튼 지원	✅
버튼 상태(활성/비활성) 처리	✅

아마도 관련된 PR들

Feature/#13 designsystem solid button #14: 솔리드 버튼 컴포넌트 도입, 디자인 시스템 버튼 구조와 유사

제안된 레이블

CodeRabbit

제안된 리뷰어

ashwon12

시

🐰 버튼들이 춤을 추네
작고 크고 다양하게
디자인 시스템의 마법
클릭! 반응! 생명이 피어나
코드 토끼의 작은 노래 🎵

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

ashwon12

이전 pr 이랑 같은 피처인 것 같아 어푸르브~ 합니다 !
고생하셨어요!

jinukeu · 2025-01-15T14:29:56Z

@coderabbitai review

coderabbitai · 2025-01-15T14:30:07Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai

Actionable comments posted: 7

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c6d0583 and 6332cc0.

📒 Files selected for processing (5)

core/designsystem/src/main/java/com/yapp/core/designsystem/component/button/text/TextAssistiveButton.kt (1 hunks)
core/designsystem/src/main/java/com/yapp/core/designsystem/component/button/text/TextButtonBasic.kt (1 hunks)
core/designsystem/src/main/java/com/yapp/core/designsystem/component/button/text/TextButtonDefaults.kt (1 hunks)
core/designsystem/src/main/java/com/yapp/core/designsystem/component/button/text/TextPrimaryButton.kt (1 hunks)
core/designsystem/src/main/java/com/yapp/core/designsystem/theme/Typography.kt (1 hunks)

🔇 Additional comments (4)

core/designsystem/src/main/java/com/yapp/core/designsystem/component/button/text/TextButtonDefaults.kt (1)

28-31: RippleAlpha 값 검토 필요

focused와 dragged 상태의 알파값(0.88f)이 일반적인 Material 디자인 가이드라인과 다릅니다. 이 값들이 의도된 것인지 확인해주세요.

core/designsystem/src/main/java/com/yapp/core/designsystem/component/button/text/TextAssistiveButton.kt (2)

3-22: 사용하지 않는 import 제거 필요

TextPrimaryButton.kt와 동일한 미사용 import들이 있습니다. 정리가 필요합니다.

70-106: Preview 함수 개선 필요

TextPrimaryButton.kt와 동일한 Preview 이슈가 있습니다. 동일한 개선이 필요합니다.

core/designsystem/src/main/java/com/yapp/core/designsystem/theme/Typography.kt (1)

Line range hint 270-274: 디자인 시스템의 일관성 검토가 필요합니다.

label1NormalBold의 폰트 두께가 700에서 600으로 변경되었습니다. 이는 다른 'Bold' 스타일들과 다른 두께를 사용하게 되어 디자인 시스템의 일관성에 영향을 줄 수 있습니다.

다음 스크립트를 실행하여 버튼 컴포넌트에서 이 스타일의 사용을 확인해주세요:

...signsystem/src/main/java/com/yapp/core/designsystem/component/button/text/TextButtonBasic.kt

...nsystem/src/main/java/com/yapp/core/designsystem/component/button/text/TextButtonDefaults.kt

...gnsystem/src/main/java/com/yapp/core/designsystem/component/button/text/TextPrimaryButton.kt

...system/src/main/java/com/yapp/core/designsystem/component/button/text/TextAssistiveButton.kt

jinukeu added the Feature 기능 추가, 개발 label Jan 14, 2025

jinukeu requested a review from ashwon12 January 14, 2025 15:45

jinukeu self-assigned this Jan 14, 2025

ashwon12 approved these changes Jan 15, 2025

View reviewed changes

jinukeu force-pushed the feature/#13-designsystem-solid-button branch from 7823fb3 to a83cab9 Compare January 15, 2025 14:21

Base automatically changed from feature/#13-designsystem-solid-button to develop January 15, 2025 14:28

jinukeu added 4 commits January 15, 2025 23:29

chore/#15: label1NormalBold FontWeight 700 -> 600

6166c49

feat/#15: TextButtonDefaults

0f6f717

feat/#15: TextButtonBasic

af26f41

feat/#15: TextButtonAssistive,Primary

6332cc0

jinukeu force-pushed the feature/#15-designsystem-button-text branch from f968f9c to 6332cc0 Compare January 15, 2025 14:29

coderabbitai bot reviewed Jan 15, 2025

View reviewed changes

jinukeu merged commit b448c16 into develop Jan 15, 2025
1 check passed

jinukeu deleted the feature/#15-designsystem-button-text branch January 15, 2025 14:34

coderabbitai bot mentioned this pull request Jan 17, 2025

Feature/#17 designsystem nestedcheckbox #19

Merged

This was referenced Jan 27, 2025

Featrue/#40 signup step 3 4 #41

Merged

Feature/#56 Switch, OutlinedSecondaryButton, SignUp 자잘한 수정 #57

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature/#15 designsystem button text #16

Feature/#15 designsystem button text #16

Uh oh!

jinukeu commented Jan 14, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jan 14, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

ashwon12 left a comment

Uh oh!

jinukeu commented Jan 15, 2025

Uh oh!

coderabbitai bot commented Jan 15, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Feature/#15 designsystem button text #16

Feature/#15 designsystem button text #16

Uh oh!

Conversation

jinukeu commented Jan 14, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💡 Issue

🌱 Key changes

✅ To Reviewers

📸 스크린샷

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

워크스루

변경 사항

연결된 이슈에 대한 평가

아마도 관련된 PR들

제안된 레이블

제안된 리뷰어

시

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

ashwon12 left a comment

Choose a reason for hiding this comment

Uh oh!

jinukeu commented Jan 15, 2025

Uh oh!

coderabbitai bot commented Jan 15, 2025

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jinukeu commented Jan 14, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 14, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)