-
Notifications
You must be signed in to change notification settings - Fork 0
Qa/1.0.0 #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Qa/1.0.0 #114
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
44245f9
fix: 이메일 입력 시 버튼이 텍스트필드 가림
jinukeu fb3f54c
feat: Firebase Crashlytics 설정 및 Proguard 규칙 추가
jinukeu 746da7c
refactor : 비밀번호 정규식 수정
jinukeu ebd9dcc
refactor: 이메일 입력 후 전부 지우는 경우에도 이메일 중복 검사 처리가 진행됨
jinukeu 6b288eb
feat: Increase versionCode to 2
jinukeu 5c55949
feat: onNewToken 예외 처리 추가
jinukeu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import com.yapp.app.setNamespace | ||
|
||
plugins { | ||
id("yapp.android.library") | ||
} | ||
|
||
android { | ||
setNamespace("core.core.common.android") | ||
} | ||
|
||
dependencies { | ||
|
||
implementation(platform(libs.firebase.bom)) | ||
implementation(libs.firebase.crashlytics) | ||
implementation(libs.timber) | ||
} |
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
# Add project specific ProGuard rules here. | ||
# You can control the set of applied configuration files using the | ||
# proguardFiles setting in build.gradle. | ||
# | ||
# For more details, see | ||
# http://developer.android.com/guide/developing/tools/proguard.html | ||
|
||
# If your project uses WebView with JS, uncomment the following | ||
# and specify the fully qualified class name to the JavaScript interface | ||
# class: | ||
#-keepclassmembers class fqcn.of.javascript.interface.for.webview { | ||
# public *; | ||
#} | ||
|
||
# Uncomment this to preserve the line number information for | ||
# debugging stack traces. | ||
#-keepattributes SourceFile,LineNumberTable | ||
|
||
# If you keep the line number information, uncomment this to | ||
# hide the original source file name. | ||
#-renamesourcefileattribute SourceFile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<manifest xmlns:android="http://schemas.android.com/apk/res/android"> | ||
|
||
</manifest> |
16 changes: 16 additions & 0 deletions
16
core/common-android/src/main/java/com/yapp/core/common/android/RecordException.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
package com.yapp.core.common.android | ||
|
||
import com.google.firebase.crashlytics.ktx.crashlytics | ||
import com.google.firebase.ktx.Firebase | ||
import timber.log.Timber | ||
|
||
fun Throwable.record() { | ||
recordException(RuntimeException(this)) | ||
} | ||
|
||
private fun recordException( | ||
e: Throwable, | ||
) { | ||
Timber.e(e) | ||
Firebase.crashlytics.recordException(e) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ package com.yapp.feature.home | |
import android.util.Log | ||
import androidx.lifecycle.ViewModel | ||
import androidx.lifecycle.viewModelScope | ||
import com.yapp.core.common.android.record | ||
import com.yapp.core.ui.component.UserRole | ||
import com.yapp.core.ui.mvi.MviIntentStore | ||
import com.yapp.core.ui.mvi.mviIntentStore | ||
|
@@ -37,8 +38,6 @@ class HomeViewModel @Inject constructor( | |
reduce: (HomeState.() -> HomeState) -> Unit, | ||
postSideEffect: (HomeSideEffect) -> Unit, | ||
) { | ||
Log.d("HomeViewModel", "intent :: $intent") | ||
|
||
when (intent) { | ||
HomeIntent.ClickMoreButton -> postSideEffect(HomeSideEffect.NavigateToNotice) | ||
HomeIntent.ClickSettingButton -> postSideEffect(HomeSideEffect.NavigateToSetting) | ||
|
@@ -55,7 +54,7 @@ class HomeViewModel @Inject constructor( | |
.catch { error-> | ||
when(error) { | ||
is UserNotFoundForEmailException, is InvalidTokenException -> postSideEffect(HomeSideEffect.NavigateToLogin) | ||
else -> throw error | ||
else -> error.record() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 앞으로 예외는 이렇게 처리하시면 됩니다. |
||
} | ||
} | ||
.collectLatest{ userInfo -> | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,3 +43,4 @@ include( | |
":feature:signup", | ||
":feature:login" | ||
) | ||
include(":core:common-android") |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Throwable을 rethrow하는 경우 stack trace에 rethrow한 위치가 남지 않아 RuntimeException으로 감샀습니다. 이러면 throw, rethrow의 stack trace 정보가 모두 남게 됩니다.