-
Notifications
You must be signed in to change notification settings - Fork 0
[YS-514] chore: Gradle 캐시 적용으로 빌드 속도 개선 #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughGitHub Actions Java CI 워크플로우에서 Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/ci-dev.yml (1)
27-36
: 공식 Gradle 캐싱 액션 사용 고려
actions/cache@v4
로 직접~/.gradle
디렉터리를 캐싱해도 무방하지만, Gradle 팀이 유지-보수하는gradle/gradle-build-action@v3
는
• 캐시 키 생성·복원,
•gradle.properties
/wrapper
변경 감지,
• 빌드-스캔 기반의 고급 옵션
을 자동으로 처리합니다. 설정이 단순해지고, Gradle 버전 업데이트 시 추가 관리 부담이 줄어듭니다.예시 diff:
- - name: Cache Gradle packages - uses: actions/cache@v4 - with: - path: | - ~/.gradle/caches - ~/.gradle/wrapper - key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }} - restore-keys: | - ${{ runner.os }}-gradle- + - name: Setup Gradle & enable caching + uses: gradle/gradle-build-action@v3기존 캐시 방식이 필요하다면 그대로 두셔도 되지만, 추후 유지보수를 위해 위 액션으로의 전환을 권장드립니다.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/ci-dev.yml
(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: Ji-soo708
PR: YAPP-Github/Gradmeet-BE#140
File: domain/src/main/kotlin/com/dobby/gateway/auth/GoogleAuthGateway.kt:7-7
Timestamp: 2025-06-04T09:02:40.657Z
Learning: Ji-soo708의 팀은 로컬 ktlint 기준과 GitHub ktlint 체크 기준이 다를 때, 기존 코드베이스와의 일관성을 위해 로컬 기준을 우선시한다.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build
- GitHub Check: Check Code Quality
🔇 Additional comments (1)
.github/workflows/ci-dev.yml (1)
40-42
:clean
단계 제거로 인한 잔존 아티팩트 영향 점검 필요
./gradlew clean test
→./gradlew test
변경으로 캐시 효율은 향상되지만,
이전 빌드 산출물이 남아 있을 경우 간헐적 재현-불가 버그가 CI에서 가려질 위험이 있습니다.
특히 annotation processor 출력이나 generated-sources 디렉터리가 의도치 않게 재사용될 수 있으니, 아래 중 한 가지를 검토해 주세요.
clean
유지: 캐시 히트율은 약간 떨어지지만 안정성 ↑--rerun-tasks
플래그 주기적 사용: 주간‧야간빌드 등에서 강제 재빌드- 테스트 단계 후에
./gradlew clean
추가하여 캐시-프라이밍과 잔존물 제거를 병행필요 시 파이프라인에서 두 명령 모두 실행해 차이를 검증해 보시기 바랍니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
테스트 실행 자체가 느려서 전체 CI 시간에서 큰 효과는 없네요 😅
💡 작업 내용
✅ 셀프 체크리스트
🙋🏻 확인해주세요
🔗 Jira 티켓
https://yappsocks.atlassian.net/browse/YS-514
Summary by CodeRabbit