-
Notifications
You must be signed in to change notification settings - Fork 0
[Feature/#49] 단일 루틴/단일 추천 루틴 API 연결 및 기존 API 호출부 점검 #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
361f1a8
FIX: API 호출 request/response를 swagger와 일치하도록 수정,
l5x5l 710b349
FEAT: 추천 루틴 기반 루틴 등록 flow 구현
l5x5l e7b9022
FEAT: 기존 루틴 기반 루틴 수정 flow 구현
l5x5l 4ce72a8
CHORE: ktlint 적용
l5x5l 7818a55
FIX: 루틴 조회시 세부 루틴이 sortOrder 순서대로 보여지도록 수정
l5x5l 74e53e7
Merge remote-tracking branch 'YAPP-Github/develop' into feature/#49-w…
l5x5l 8be01f0
CHORE: ktlint 적용
l5x5l 94f1300
CHORE: 일부 라인 개행
l5x5l File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
data/src/main/java/com/threegap/bitnagil/data/emotion/datasource/EmotionDataSource.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
package com.threegap.bitnagil.data.emotion.datasource | ||
|
||
import com.threegap.bitnagil.data.emotion.model.response.GetEmotionsResponse | ||
import com.threegap.bitnagil.data.emotion.model.dto.EmotionDto | ||
import com.threegap.bitnagil.data.emotion.model.response.MyEmotionResponseDto | ||
import com.threegap.bitnagil.data.emotion.model.response.RegisterEmotionResponse | ||
|
||
interface EmotionDataSource { | ||
suspend fun getEmotions(): Result<GetEmotionsResponse> | ||
suspend fun getEmotions(): Result<List<EmotionDto>> | ||
suspend fun registerEmotion(emotion: String): Result<RegisterEmotionResponse> | ||
suspend fun getMyEmotionMarble(currentDate: String): Result<MyEmotionResponseDto> | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
data/src/main/java/com/threegap/bitnagil/data/emotion/model/dto/EmotionDto.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
package com.threegap.bitnagil.data.emotion.model.dto | ||
|
||
import kotlinx.serialization.SerialName | ||
import kotlinx.serialization.Serializable | ||
|
||
@Serializable | ||
data class EmotionDto( | ||
@SerialName("emotionMarbleType") | ||
val emotionMarbleType: String, | ||
@SerialName("emotionMarbleName") | ||
val emotionMarbleName: String, | ||
@SerialName("imageUrl") | ||
val imageUrl: String, | ||
) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 0 additions & 10 deletions
10
data/src/main/java/com/threegap/bitnagil/data/emotion/model/response/GetEmotionsResponse.kt
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
...java/com/threegap/bitnagil/data/recommendroutine/datasource/RecommendRoutineDataSource.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,9 @@ | ||
package com.threegap.bitnagil.data.recommendroutine.datasource | ||
|
||
import com.threegap.bitnagil.data.recommendroutine.model.response.RecommendRoutinesDto | ||
import com.threegap.bitnagil.data.recommendroutine.model.response.RecommendedRoutineDto | ||
|
||
interface RecommendRoutineDataSource { | ||
suspend fun fetchRecommendRoutines(): Result<RecommendRoutinesDto> | ||
suspend fun getRecommendRoutine(recommendRoutineId: Int): Result<RecommendedRoutineDto> | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
.../main/java/com/threegap/bitnagil/data/recommendroutine/service/RecommendRoutineService.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,17 @@ | ||
package com.threegap.bitnagil.data.recommendroutine.service | ||
|
||
import com.threegap.bitnagil.data.recommendroutine.model.response.RecommendRoutinesDto | ||
import com.threegap.bitnagil.data.recommendroutine.model.response.RecommendedRoutineDto | ||
import com.threegap.bitnagil.network.model.BaseResponse | ||
import retrofit2.http.GET | ||
import retrofit2.http.Path | ||
|
||
interface RecommendRoutineService { | ||
@GET("/api/v1/recommend-routines") | ||
suspend fun fetchRecommendRoutines(): BaseResponse<RecommendRoutinesDto> | ||
|
||
@GET("/api/v1/recommend-routines/{recommendedRoutineId}") | ||
suspend fun getRecommendRoutine( | ||
@Path("recommendedRoutineId") recommendedRoutineId: Int, | ||
): BaseResponse<RecommendedRoutineDto> | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 0 additions & 2 deletions
2
...rc/main/java/com/threegap/bitnagil/data/writeroutine/datasource/WriteRoutineDataSource.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,9 @@ | ||
package com.threegap.bitnagil.data.writeroutine.datasource | ||
|
||
import com.threegap.bitnagil.data.writeroutine.model.dto.RoutineDto | ||
import com.threegap.bitnagil.data.writeroutine.model.request.EditRoutineRequest | ||
import com.threegap.bitnagil.data.writeroutine.model.request.RegisterRoutineRequest | ||
|
||
interface WriteRoutineDataSource { | ||
suspend fun registerRoutine(request: RegisterRoutineRequest): Result<Unit> | ||
suspend fun editRoutine(request: EditRoutineRequest): Result<Unit> | ||
suspend fun getRoutine(routineId: String): Result<RoutineDto> | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.