Skip to content

Conversation

wjdrjs00
Copy link
Member

@wjdrjs00 wjdrjs00 commented Jul 29, 2025

[ PR Content ]

마이페이지 및 설정화면 디자인 추가 사항을 반영했습니다.

Related issue

Screenshot 📸

Screen_recording_20250730_041508.mp4

Work Description

  • 기본 프로필 이미지 추가
  • 로그아웃, 회원탈퇴 시 다이얼로그 추가

To Reviewers 📢

  • 마이페이지 화면 유저 이름 api 연동이 남았습니다..!

Summary by CodeRabbit

  • 신규 기능

    • 로그아웃 및 회원탈퇴 시 사용자 확인을 위한 확인 다이얼로그가 추가되었습니다.
    • 설정 화면에서 로그아웃/회원탈퇴 버튼 클릭 시 확인 다이얼로그가 표시됩니다.
    • 경고 아이콘 및 기본 프로필 이미지가 새롭게 적용되었습니다.
  • UI 개선

    • 마이페이지의 기본 프로필 이미지가 아이콘 형태로 변경되고 크기가 조정되었습니다.

@wjdrjs00 wjdrjs00 requested a review from l5x5l July 29, 2025 19:16
@wjdrjs00 wjdrjs00 self-assigned this Jul 29, 2025
@wjdrjs00 wjdrjs00 added ✨ Feature 새로운 기능 구현 🧤 대현 labels Jul 29, 2025
Copy link

coderabbitai bot commented Jul 29, 2025

"""

Walkthrough

이 변경 사항은 마이페이지와 설정 화면에 새로운 디자인 요소를 반영합니다. 기본 프로필 사진 벡터 이미지가 추가되고, 로그아웃 및 회원 탈퇴 시 사용자 확인 다이얼로그가 도입되었습니다. 관련 UI, 상태, Intent, ViewModel, Enum 및 리소스 파일이 추가·수정되었습니다.

Changes

Cohort / File(s) Change Summary
기본 프로필 및 경고 아이콘 리소스 추가
core/designsystem/src/main/res/drawable/ic_warning.xml, core/designsystem/src/main/res/drawable/img_default_progile.xml
경고 아이콘과 기본 프로필 벡터 이미지 리소스 파일 추가
마이페이지 프로필 이미지 적용
presentation/src/main/java/com/threegap/bitnagil/presentation/mypage/MyPageScreen.kt
기본 프로필 이미지를 벡터 리소스로 교체, 이미지 크기 90dp로 확대
설정 화면 다이얼로그 도입 및 상태 연동
presentation/src/main/java/com/threegap/bitnagil/presentation/setting/SettingScreen.kt, presentation/src/main/java/com/threegap/bitnagil/presentation/setting/SettingViewModel.kt, presentation/src/main/java/com/threegap/bitnagil/presentation/setting/model/mvi/SettingIntent.kt, presentation/src/main/java/com/threegap/bitnagil/presentation/setting/model/mvi/SettingState.kt
로그아웃/탈퇴 버튼 클릭 시 확인 다이얼로그 노출 및 상태, Intent, ViewModel 함수 추가 및 연동
확인 다이얼로그 컴포저블 및 타입 정의
presentation/src/main/java/com/threegap/bitnagil/presentation/setting/component/block/ConfirmDialog.kt, presentation/src/main/java/com/threegap/bitnagil/presentation/setting/model/ConfirmDialogType.kt
커스텀 확인 다이얼로그 컴포저블 및 다이얼로그 타입 Enum 추가

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SettingScreen
    participant SettingViewModel
    participant ConfirmDialog

    User->>SettingScreen: 로그아웃/탈퇴 버튼 클릭
    SettingScreen->>SettingViewModel: showLogoutDialog() / showWithdrawalDialog()
    SettingViewModel->>SettingScreen: state.showConfirmDialog = (LOGOUT/WITHDRAW)
    SettingScreen->>ConfirmDialog: showConfirmDialog != null
    User->>ConfirmDialog: 확인 버튼 클릭
    ConfirmDialog->>SettingViewModel: confirmDialogAction()
    SettingViewModel->>SettingScreen: executeLogout()/executeWithdrawal(), showConfirmDialog = null
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Assessment against linked issues

Objective Addressed Explanation
기본 프로필 사진 적용 (#53)
로그아웃, 회원 탈퇴에 대한 다이얼로그 추가 (#53)

Suggested labels

세환

Suggested reviewers

  • l5x5l

Poem

🐰
새로운 프로필, 경고 아이콘 반짝!
로그아웃, 탈퇴도 이제는 묻고 또 묻지.
다이얼로그 등장에 마음이 놓여,
토끼도 안심하고 버튼을 눌러!
디자인 한 스푼, 안전 한 스푼,
오늘도 코드를 사랑해, 깡총!

"""

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dc3d6f9 and f8b7b9d.

📒 Files selected for processing (2)
  • presentation/src/main/java/com/threegap/bitnagil/presentation/setting/SettingViewModel.kt (5 hunks)
  • presentation/src/main/java/com/threegap/bitnagil/presentation/setting/model/mvi/SettingIntent.kt (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • presentation/src/main/java/com/threegap/bitnagil/presentation/setting/model/mvi/SettingIntent.kt
  • presentation/src/main/java/com/threegap/bitnagil/presentation/setting/SettingViewModel.kt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/#53-mypage-setting-ui

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

- ConfirmDialogAction Intent 제거
Copy link
Contributor

@l5x5l l5x5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@wjdrjs00 wjdrjs00 merged commit 5b111d8 into develop Jul 30, 2025
2 checks passed
@wjdrjs00 wjdrjs00 deleted the feature/#53-mypage-setting-ui branch July 30, 2025 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 새로운 기능 구현 🧤 대현
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] 마이페이지 및 설정화면 디자인 추가 사항 반영
2 participants