fix local inlined svg symbols from embedding entire page #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@snshn - This PR is ready for review. Is there anyone else who should be involved to get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents SVGs with
xlink:href/hreffragments to inlined symbols in the same document from resolving to the full page URL. This addresses an unintended consequence of #435 that results in inflated file size on some sites, the most obvious culprit being allrecipes.com.This should also address some of the reports in karakeep-app/karakeep#770
Here are a few examples with default options showing significant reduction in archive size by about 96% with identical rendering (sometimes improved, as the browser will give up if the archive is too large):