Skip to content

Commit 6690c14

Browse files
committed
enhance: Check PyMilvus on Windows platform
See also: milvus-io#2134 Signed-off-by: yangxuan <[email protected]>
1 parent 9c914bf commit 6690c14

File tree

5 files changed

+8
-5
lines changed

5 files changed

+8
-5
lines changed

.github/workflows/check_milvus_proto.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
- name: Install dependencies
2727
run: |
2828
python -m pip install --upgrade pip
29-
pip install -e .
29+
pip install -e ".[dev]"
3030
3131
- name: Try generate proto
3232
run: |

.github/workflows/code_checker.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
uses: actions/setup-python@v5
2020
with:
2121
python-version: ${{ matrix.python-version }}
22-
- name: check pyproject.toml install
22+
- name: Check pyproject.toml install
2323
run: |
2424
pip install -e .
2525
- name: Install requirements

.github/workflows/pull_request.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,11 @@ on:
88
jobs:
99
build:
1010
name: Run Python Tests
11-
runs-on: ubuntu-latest
1211
strategy:
1312
matrix:
1413
python-version: [3.8, 3.12]
14+
os: [ubuntu-latest, windows-latest]
15+
runs-on: ${{ matrix.os }}
1516

1617
steps:
1718
- name: Checkout code

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ get_proto:
2525
git submodule update --init
2626

2727
gen_proto:
28-
python3 -m pip install -e ".[dev]"
28+
pip install -e ".[dev]"
2929
cd pymilvus/grpc_gen && ./python_gen.sh
3030

3131
check_proto_product: gen_proto

tests/test_milvus_lite.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
import os
2+
import sys
23
from tempfile import TemporaryDirectory
34
import numpy as np
5+
import pytest
46

57
from pymilvus.milvus_client import MilvusClient
68

79

10+
@pytest.mark.skipif(sys.platform.startswith('win'), reason="Milvus Lite is not supported on Windows")
811
class TestMilvusLite:
9-
1012
def test_milvus_lite(self):
1113
with TemporaryDirectory(dir='./') as root:
1214
db_file = os.path.join(root, 'test.db')

0 commit comments

Comments
 (0)