Skip to content

Commit 9c914bf

Browse files
RaysilienceXuanYang-cn
authored andcommitted
feat: disable installation of milvus-lite on windows platform (milvus-io#2131) (milvus-io#2134)
Since the project is managed by setuptools, and according to the [setuptools](https://setuptools.pypa.io/en/latest/userguide/dependency_management.html), we can disable the automatic installation of milvus-lite on windows platform by adding environment markers. Following [PEP508](https://peps.python.org/pep-0508/), I pick the environment marker "sys_platform != 'win32'" to prevent the installation. I build packages after the modification. Then test the .tar.gz and the .whl files both on my windows laptop and a linux docker. The issue mentioned in milvus-io#2131 seems gone. Due the lack of macOS machine, I could not perform testing on that particular platform. Please check validity before merging. Signed-off-by: rui zhang <[email protected]>
1 parent c9f87bc commit 9c914bf

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ dependencies=[
2525
"pandas>=1.2.4",
2626
"numpy<1.25.0;python_version<='3.8'",
2727
"milvus_lite>=2.4.0,<2.5.0",
28+
"milvus-lite>=2.4.0,<2.5.0;sys_platform!='win32'",
2829
]
2930

3031
classifiers=[

0 commit comments

Comments
 (0)