Skip to content

Xiangyu/unified ck tests #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 21, 2025
Merged

Xiangyu/unified ck tests #899

merged 5 commits into from
Aug 21, 2025

Conversation

Xiangyu-Hu
Copy link
Owner

This pull request introduces several improvements and refactorings to the continuum dynamics CK (Compute Kernel) modules, enhances execution policy selection for SYCL support, and cleans up headers and file naming conventions. The changes collectively improve code clarity, maintainability, and compatibility with SYCL-enabled builds.

CK Continuum Dynamics Refactoring and Cleanup

  • Refactored and renamed headers and implementation files for continuum dynamics CK modules to use correct spelling (initialization instead of initilization) and improved file organization. Old headers and implementations were removed and replaced with new, consistently named files. [1] [2] [3]
  • Moved constructor and kernel implementations for VerticalStressCK, AccDeviatoricPlasticStrainCK, and ContinuumInitialConditionCK from header files to corresponding .cpp files, improving separation of interface and implementation. [1] [2]
  • Changed kernel update methods to be marked inline for improved performance and clarity. [1] [2] [3] [4]

SYCL and Execution Policy Improvements

  • Added conditional compilation for SYCL support, including new SYCL-related headers in sphinxsys.h and defining MainExecutionPolicy and par_ck to select the appropriate execution policy depending on whether SYCL is enabled. [1] [2]

General Codebase Cleanup

  • Updated author lists and file documentation comments for greater accuracy and clarity. [1] [2] [3]
  • Fixed typos in file names and documentation (e.g., continum to continuum, initilization to initialization). [1] [2]
  • Removed the obsolete umbrella header sphinxsys_ck.h, consolidating CK module includes and improving modularity.

Minor API Changes

  • Updated constructors in LevelSetShape and methods in MultilevelLevelSet to use the new, templated execution policy approach, improving flexibility and consistency. [1] [2]

Build and Include Consistency

  • Ensured all necessary CK and SYCL headers are included conditionally and consistently, reducing build errors and improving portability. [1] [2]

These changes collectively improve code clarity, maintainability, and SYCL compatibility for continuum dynamics and related modules.

@Xiangyu-Hu Xiangyu-Hu requested a review from Lisu-lisa August 20, 2025 21:10
@Xiangyu-Hu Xiangyu-Hu requested a review from DongWuTUM August 21, 2025 11:41
@Xiangyu-Hu Xiangyu-Hu merged commit 3619b2e into master Aug 21, 2025
7 checks passed
@Xiangyu-Hu Xiangyu-Hu deleted the xiangyu/unified_ck_tests branch August 21, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants