Skip to content

Chore: Three small fixes #4922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 23, 2025
Merged

Chore: Three small fixes #4922

merged 5 commits into from
Jul 23, 2025

Conversation

patterniha
Copy link
Collaborator

@patterniha patterniha commented Jul 23, 2025

merge of #4909, #4910, #4911

  1. fix a (nearly impossible) situation problem when a udp packet received exactly after 2 minutes of inactivity(a race condition problem may happen)

  2. fix some rare situations problem when udpConn is closed, but connEntry not closed(for example when we have two interface and one is down...)

  3. fix redundant request to vless fallback when connection is closed

///

for 1 and 2, if you want I can fully explain the situation and 3 is also clear.

@RPRX
Copy link
Member

RPRX commented Jul 23, 2025

发了下个版本后再看

@Fangliding
Copy link
Member

image 突出一个孜孜不倦

@patterniha
Copy link
Collaborator Author

patterniha commented Jul 23, 2025

@RPRX

I checked and test, Im sure about this PR, I fully trace the code for all.

Some bugs like udp-mismatched-address, sniff-infinite-loop and close-connecion-not-belong is important and some like this is small, but code should be perfect and all small and big bugs should be fixed.

I think you can trust me after about 25 fixed bugs

@patterniha
Copy link
Collaborator Author

Check it out after the next version is released

If you have any doubts about any of them, I can explain them in full now.

@RPRX
Copy link
Member

RPRX commented Jul 23, 2025

那等我给 README 加完 NFT 图像就合,反正等下 pre-release 测下你们这些 PR 有没有问题

@Fangliding
Copy link
Member

最好晾会 不然发版之后估计还得来几个small refines

@RPRX
Copy link
Member

RPRX commented Jul 23, 2025

@patterniha 还会有吗

@patterniha
Copy link
Collaborator Author

Not for this version.

I'm trying to solve the WireGuard and some xhttp problems, but it won't reach this version

@RPRX
Copy link
Member

RPRX commented Jul 23, 2025

有精力的话研究一下 WireGuard 吧,目前出入站都有点小问题

@patterniha
Copy link
Collaborator Author

patterniha commented Jul 23, 2025

OK, so please merge this PR for today new version.

@RPRX
Copy link
Member

RPRX commented Jul 23, 2025

其实 VLESS 回落那里的话,原本的代码可以输出个日志,并且返回时最好包一层 errors.New()

不过算了,REALITY 出来后 VLESS fallbacks 的代码都没那么重要了,我懒得改

@RPRX RPRX changed the title small refines Chore: Three small fixes Jul 23, 2025
@RPRX RPRX merged commit 4e826ab into XTLS:main Jul 23, 2025
39 checks passed
@patterniha patterniha deleted the only-3-merges branch July 23, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants