-
Notifications
You must be signed in to change notification settings - Fork 15
[src/{bin/main,global,lib}.rs] Add new additional_derives
vec CLI opt…
#145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ption ; [src/code.rs] Fix type elision warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change, this was likely overdue.
Though there are some extra changes that should be done:
- the commit message style we use is conventional/angular (though with the scope of this PR, i might just squash and change the message myself)
- add tests for this new option (see existing tests for examples)
- remove the
Option
wrapping as listed in the comments below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better, tests are still missing though. See simple_table_sqlite
for a simple example.
; [src/code.rs] Fix type elision warning
Basically I am getting this issue:
utoipa::ToSchema
needs to be on thestruct
. But it's a bit too specific to make it to this library/cli, and regardless doesn't futureproof dsync.So this just lets you add arbitrary derives as strings. As many as your heart desires.
--help