Skip to content

Conversation

sarayourfriend
Copy link
Collaborator

Fixes

Related to #933

Description

If the heavy queries are coming from admin (which it looks like they are), then we can disable the media model admins and avoid them. If they aren't coming from here, then we've already cut out one potential source of these queries and can look elsewhere.

Testing Instructions

Run the application locally and visit /admin and confirm that the deregistered admin views are no longer available. Check /admin/api/image for example to check specifically that it's absolutely not available.

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • [N/A] I added or updated tests for the changes I made (if applicable).
  • [N/A] I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend sarayourfriend added 🟥 priority: critical Must be addressed ASAP 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: api Related to the Django API labels Mar 17, 2023
@sarayourfriend sarayourfriend requested a review from a team as a code owner March 17, 2023 00:01
@zackkrida zackkrida merged commit a0b17d3 into main Mar 17, 2023
@zackkrida zackkrida deleted the add/deregister-image-audio-admin branch March 17, 2023 00:25
@krysal krysal mentioned this pull request Mar 29, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟥 priority: critical Must be addressed ASAP 🧱 stack: api Related to the Django API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants