Update pinia and pinia/testing #917

obulat · 2023-03-15T09:22:40Z

Fixes

Replaces #582

Description

This is a manual Pinia and pinia/testing update. When added on top of the Vue version update, the changes are limited to 13 lines in the lock file.

The related Nuxt module is not updated because it only supports Nuxt 3.

Testing Instructions

The CI should pass.

Checklist

My pull request has a descriptive title (not a vague title like
Update index.md).
My pull request targets the default branch of the repository (main) or
a parent feature branch.
My commit messages follow best practices.
My code follows the established code style of the repository.
I added or updated tests for the changes I made (if applicable).
I added or updated documentation (if applicable).
I tried running the project locally and verified that there are no visible
errors.

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

github-actions · 2023-03-15T09:29:00Z

Full-stack documentation: Updating

(This comment will be automatically updated with the preview URL once it is ready)

github-actions · 2023-03-15T09:29:40Z

Size Change: +390 B (0%)

Total Size: 878 kB

Filename	Size	Change
`./frontend/.nuxt/dist/client/vendors/app.js`	63.5 kB	+191 B (0%)
`./frontend/.nuxt/dist/client/vendors/app.modern.js`	62.5 kB	+199 B (0%)

ℹ️ View Unchanged

Filename	Size
`./frontend/.nuxt/dist/client/235.js`	273 B
`./frontend/.nuxt/dist/client/235.modern.js`	277 B
`./frontend/.nuxt/dist/client/236.js`	1.85 kB
`./frontend/.nuxt/dist/client/app.js`	143 kB
`./frontend/.nuxt/dist/client/app.modern.js`	117 kB
`./frontend/.nuxt/dist/client/commons/app.js`	87.8 kB
`./frontend/.nuxt/dist/client/commons/app.modern.js`	78.2 kB
`./frontend/.nuxt/dist/client/components/loading-icon.js`	746 B
`./frontend/.nuxt/dist/client/components/loading-icon.modern.js`	753 B
`./frontend/.nuxt/dist/client/components/table-sort-icon.js`	514 B
`./frontend/.nuxt/dist/client/components/table-sort-icon.modern.js`	519 B
`./frontend/.nuxt/dist/client/components/v-all-results-grid.js`	8.02 kB
`./frontend/.nuxt/dist/client/components/v-all-results-grid.modern.js`	5.48 kB
`./frontend/.nuxt/dist/client/components/v-audio-cell.js`	392 B
`./frontend/.nuxt/dist/client/components/v-audio-cell.modern.js`	396 B
`./frontend/.nuxt/dist/client/components/v-audio-details.js`	2.55 kB
`./frontend/.nuxt/dist/client/components/v-audio-details.modern.js`	1.79 kB
`./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.js`	1.02 kB
`./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.modern.js`	1.02 kB
`./frontend/.nuxt/dist/client/components/v-audio-track.js`	5.23 kB
`./frontend/.nuxt/dist/client/components/v-audio-track.modern.js`	5.17 kB
`./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.js`	542 B
`./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.modern.js`	547 B
`./frontend/.nuxt/dist/client/components/v-bone.js`	693 B
`./frontend/.nuxt/dist/client/components/v-bone.modern.js`	697 B
`./frontend/.nuxt/dist/client/components/v-box-layout.js`	1.24 kB
`./frontend/.nuxt/dist/client/components/v-box-layout.modern.js`	1.24 kB
`./frontend/.nuxt/dist/client/components/v-content-link.js`	1.12 kB
`./frontend/.nuxt/dist/client/components/v-content-link.modern.js`	1.1 kB
`./frontend/.nuxt/dist/client/components/v-content-page.js`	526 B
`./frontend/.nuxt/dist/client/components/v-content-page.modern.js`	530 B
`./frontend/.nuxt/dist/client/components/v-content-report-button.js`	786 B
`./frontend/.nuxt/dist/client/components/v-content-report-button.modern.js`	789 B
`./frontend/.nuxt/dist/client/components/v-content-report-form.js`	6.11 kB
`./frontend/.nuxt/dist/client/components/v-content-report-form.modern.js`	3.59 kB
`./frontend/.nuxt/dist/client/components/v-content-report-popover.js`	1.24 kB
`./frontend/.nuxt/dist/client/components/v-content-report-popover.modern.js`	4.25 kB
`./frontend/.nuxt/dist/client/components/v-copy-button.js`	4 kB
`./frontend/.nuxt/dist/client/components/v-copy-button.modern.js`	4.01 kB
`./frontend/.nuxt/dist/client/components/v-copy-license.js`	1 kB
`./frontend/.nuxt/dist/client/components/v-copy-license.modern.js`	1.01 kB
`./frontend/.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/d219393b.js`	9.95 kB
`./frontend/.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/d219393b.modern.js`	9.93 kB
`./frontend/.nuxt/dist/client/components/v-dmca-notice.js`	754 B
`./frontend/.nuxt/dist/client/components/v-dmca-notice.modern.js`	759 B
`./frontend/.nuxt/dist/client/components/v-error-image.js`	1.7 kB
`./frontend/.nuxt/dist/client/components/v-error-image.modern.js`	1.69 kB
`./frontend/.nuxt/dist/client/components/v-error-section.js`	372 B
`./frontend/.nuxt/dist/client/components/v-error-section.modern.js`	376 B
`./frontend/.nuxt/dist/client/components/v-external-search-form.js`	1.92 kB
`./frontend/.nuxt/dist/client/components/v-external-search-form.modern.js`	1.92 kB
`./frontend/.nuxt/dist/client/components/v-external-source-list.js`	903 B
`./frontend/.nuxt/dist/client/components/v-external-source-list.modern.js`	907 B
`./frontend/.nuxt/dist/client/components/v-full-layout.js`	1.52 kB
`./frontend/.nuxt/dist/client/components/v-full-layout.modern.js`	1.52 kB
`./frontend/.nuxt/dist/client/components/v-grid-skeleton.js`	1.62 kB
`./frontend/.nuxt/dist/client/components/v-grid-skeleton.modern.js`	1.63 kB
`./frontend/.nuxt/dist/client/components/v-home-gallery.js`	4.8 kB
`./frontend/.nuxt/dist/client/components/v-home-gallery.modern.js`	4.8 kB
`./frontend/.nuxt/dist/client/components/v-homepage-content.js`	1.76 kB
`./frontend/.nuxt/dist/client/components/v-homepage-content.modern.js`	1.73 kB
`./frontend/.nuxt/dist/client/components/v-image-carousel.js`	4.73 kB
`./frontend/.nuxt/dist/client/components/v-image-carousel.modern.js`	4.71 kB
`./frontend/.nuxt/dist/client/components/v-image-cell.js`	1.57 kB
`./frontend/.nuxt/dist/client/components/v-image-cell.modern.js`	1.56 kB
`./frontend/.nuxt/dist/client/components/v-image-details.js`	2.17 kB
`./frontend/.nuxt/dist/client/components/v-image-details.modern.js`	1.43 kB
`./frontend/.nuxt/dist/client/components/v-image-grid.js`	4.99 kB
`./frontend/.nuxt/dist/client/components/v-image-grid.modern.js`	2.52 kB
`./frontend/.nuxt/dist/client/components/v-license-tab-panel.js`	526 B
`./frontend/.nuxt/dist/client/components/v-license-tab-panel.modern.js`	529 B
`./frontend/.nuxt/dist/client/components/v-load-more.js`	3.17 kB
`./frontend/.nuxt/dist/client/components/v-load-more.modern.js`	694 B
`./frontend/.nuxt/dist/client/components/v-media-license.js`	827 B
`./frontend/.nuxt/dist/client/components/v-media-license.modern.js`	836 B
`./frontend/.nuxt/dist/client/components/v-media-reuse.js`	1.63 kB
`./frontend/.nuxt/dist/client/components/v-media-reuse.modern.js`	1.63 kB
`./frontend/.nuxt/dist/client/components/v-media-tag.js`	435 B
`./frontend/.nuxt/dist/client/components/v-media-tag.modern.js`	438 B
`./frontend/.nuxt/dist/client/components/v-modal.js`	1.01 kB
`./frontend/.nuxt/dist/client/components/v-modal.modern.js`	995 B
`./frontend/.nuxt/dist/client/components/v-no-results.js`	757 B
`./frontend/.nuxt/dist/client/components/v-no-results.modern.js`	756 B
`./frontend/.nuxt/dist/client/components/v-radio.js`	1.51 kB
`./frontend/.nuxt/dist/client/components/v-radio.modern.js`	1.47 kB
`./frontend/.nuxt/dist/client/components/v-related-audio.js`	1.26 kB
`./frontend/.nuxt/dist/client/components/v-related-audio.modern.js`	1.27 kB
`./frontend/.nuxt/dist/client/components/v-related-images.js`	1.06 kB
`./frontend/.nuxt/dist/client/components/v-related-images.modern.js`	3.09 kB
`./frontend/.nuxt/dist/client/components/v-report-desc-form.js`	977 B
`./frontend/.nuxt/dist/client/components/v-report-desc-form.modern.js`	981 B
`./frontend/.nuxt/dist/client/components/v-row-layout.js`	1.71 kB
`./frontend/.nuxt/dist/client/components/v-row-layout.modern.js`	1.72 kB
`./frontend/.nuxt/dist/client/components/v-scroll-button.js`	825 B
`./frontend/.nuxt/dist/client/components/v-scroll-button.modern.js`	830 B
`./frontend/.nuxt/dist/client/components/v-search-grid.js`	5.75 kB
`./frontend/.nuxt/dist/client/components/v-search-grid.modern.js`	5.68 kB
`./frontend/.nuxt/dist/client/components/v-search-results-title.js`	599 B
`./frontend/.nuxt/dist/client/components/v-search-results-title.modern.js`	605 B
`./frontend/.nuxt/dist/client/components/v-search-type-radio.js`	805 B
`./frontend/.nuxt/dist/client/components/v-search-type-radio.modern.js`	781 B
`./frontend/.nuxt/dist/client/components/v-server-timeout.js`	299 B
`./frontend/.nuxt/dist/client/components/v-server-timeout.modern.js`	303 B
`./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.js`	3.4 kB
`./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js`	912 B
`./frontend/.nuxt/dist/client/components/v-snackbar.js`	1.19 kB
`./frontend/.nuxt/dist/client/components/v-snackbar.modern.js`	1.19 kB
`./frontend/.nuxt/dist/client/components/v-sources-table.js`	16.2 kB
`./frontend/.nuxt/dist/client/components/v-sources-table.modern.js`	16.2 kB
`./frontend/.nuxt/dist/client/components/v-warning-suppressor.js`	306 B
`./frontend/.nuxt/dist/client/components/v-warning-suppressor.modern.js`	311 B
`./frontend/.nuxt/dist/client/pages/about.js`	1.4 kB
`./frontend/.nuxt/dist/client/pages/about.modern.js`	1.4 kB
`./frontend/.nuxt/dist/client/pages/audio/_id/index.js`	8.02 kB
`./frontend/.nuxt/dist/client/pages/audio/_id/index.modern.js`	4.86 kB
`./frontend/.nuxt/dist/client/pages/external-sources.js`	1.56 kB
`./frontend/.nuxt/dist/client/pages/external-sources.modern.js`	1.56 kB
`./frontend/.nuxt/dist/client/pages/feedback.js`	1.34 kB
`./frontend/.nuxt/dist/client/pages/feedback.modern.js`	1.34 kB
`./frontend/.nuxt/dist/client/pages/image/_id/index.js`	9.32 kB
`./frontend/.nuxt/dist/client/pages/image/_id/index.modern.js`	5.18 kB
`./frontend/.nuxt/dist/client/pages/image/_id/report.js`	3.65 kB
`./frontend/.nuxt/dist/client/pages/image/_id/report.modern.js`	4.25 kB
`./frontend/.nuxt/dist/client/pages/index.js`	6.9 kB
`./frontend/.nuxt/dist/client/pages/index.modern.js`	6.84 kB
`./frontend/.nuxt/dist/client/pages/preferences.js`	1.32 kB
`./frontend/.nuxt/dist/client/pages/preferences.modern.js`	1.32 kB
`./frontend/.nuxt/dist/client/pages/privacy.js`	1.01 kB
`./frontend/.nuxt/dist/client/pages/privacy.modern.js`	1.02 kB
`./frontend/.nuxt/dist/client/pages/search-help.js`	1.6 kB
`./frontend/.nuxt/dist/client/pages/search-help.modern.js`	1.58 kB
`./frontend/.nuxt/dist/client/pages/search.js`	4.56 kB
`./frontend/.nuxt/dist/client/pages/search.modern.js`	2.04 kB
`./frontend/.nuxt/dist/client/pages/search/audio.js`	6.03 kB
`./frontend/.nuxt/dist/client/pages/search/audio.modern.js`	3.54 kB
`./frontend/.nuxt/dist/client/pages/search/image.js`	508 B
`./frontend/.nuxt/dist/client/pages/search/image.modern.js`	2.7 kB
`./frontend/.nuxt/dist/client/pages/search/index.js`	443 B
`./frontend/.nuxt/dist/client/pages/search/index.modern.js`	447 B
`./frontend/.nuxt/dist/client/pages/search/model-3d.js`	243 B
`./frontend/.nuxt/dist/client/pages/search/model-3d.modern.js`	246 B
`./frontend/.nuxt/dist/client/pages/search/search-page.types.js`	266 B
`./frontend/.nuxt/dist/client/pages/search/search-page.types.modern.js`	271 B
`./frontend/.nuxt/dist/client/pages/search/video.js`	240 B
`./frontend/.nuxt/dist/client/pages/search/video.modern.js`	244 B
`./frontend/.nuxt/dist/client/pages/sources.js`	1.57 kB
`./frontend/.nuxt/dist/client/pages/sources.modern.js`	1.57 kB
`./frontend/.nuxt/dist/client/runtime.js`	2.72 kB
`./frontend/.nuxt/dist/client/runtime.modern.js`	2.73 kB

_{compressed-size-action}

dhruvkb

LGTM! Looks like this includes #916. We should close that then if this gets merged.

obulat · 2023-03-15T16:46:06Z

LGTM! Looks like this includes #916. We should close that then if this gets merged.

I would prefer to merge #916 first, and then merge the other 2, @dhruvkb.

After we moved the "ignore warning" code from frontend/package.json to package.json, pnpm install adds a lot of changes to the lock file (adding something like "React is an optional peer dependency"). All of them are in #916.

dhruvkb · 2023-03-15T16:47:53Z

@obulat Fair enough. Approved #916 as well. Thanks for explaining 👍!

obulat requested a review from a team as a code owner March 15, 2023 09:22

obulat requested review from zackkrida and dhruvkb March 15, 2023 09:22

github-actions bot added the 🧱 stack: frontend Related to the Nuxt frontend label Mar 15, 2023

obulat added 🟩 priority: low Low priority and doesn't need to be rushed 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Mar 15, 2023

obulat mentioned this pull request Mar 15, 2023

Update dependency @pinia/testing to ^0.0.15 #582

Closed

1 task

dhruvkb approved these changes Mar 15, 2023

View reviewed changes

zackkrida approved these changes Mar 16, 2023

View reviewed changes

Update pinia and pinia/testing

3de50b0

obulat force-pushed the update/pinia branch from 730c75e to 3de50b0 Compare March 17, 2023 03:48

obulat merged commit 0ae48e6 into main Mar 17, 2023

obulat deleted the update/pinia branch March 17, 2023 04:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update pinia and pinia/testing #917

Update pinia and pinia/testing #917

Uh oh!

obulat commented Mar 15, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Mar 15, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Mar 15, 2023 •

edited

Loading

Uh oh!

dhruvkb left a comment

Uh oh!

obulat commented Mar 15, 2023

Uh oh!

dhruvkb commented Mar 15, 2023

Uh oh!

Uh oh!

Update pinia and pinia/testing #917

Update pinia and pinia/testing #917

Uh oh!

Conversation

obulat commented Mar 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixes

Description

Testing Instructions

Checklist

Developer Certificate of Origin

Uh oh!

github-actions bot commented Mar 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dhruvkb left a comment

Choose a reason for hiding this comment

Uh oh!

obulat commented Mar 15, 2023

Uh oh!

dhruvkb commented Mar 15, 2023

Uh oh!

Uh oh!

obulat commented Mar 15, 2023 •

edited

Loading

github-actions bot commented Mar 15, 2023 •

edited

Loading

github-actions bot commented Mar 15, 2023 •

edited

Loading