Only run stack label addition step on pull requests #882

AetherUnbound · 2023-03-09T19:14:56Z

Description

Small fix/follow up to #786, this prevents the "Add stack label" action from running on anything that isn't a pull request. See a failed run which occurred on the "push" action here: https://github.com/WordPress/openverse/actions/runs/4369574126/jobs/7643514186

Testing Instructions

Merge 🙂

Checklist

My pull request has a descriptive title (not a vague title like
Update index.md).
My pull request targets the default branch of the repository (main) or
a parent feature branch.
My commit messages follow best practices.
My code follows the established code style of the repository.
I added or updated tests for the changes I made (if applicable).
I added or updated documentation (if applicable).
I tried running the project locally and verified that there are no visible
errors.

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

github-actions · 2023-03-09T19:22:52Z

Full-stack documentation: Ready

https://WordPress.github.io/openverse/_preview/882

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

obulat

Let's test it 😄

dhruvkb

Also add the condition to not run it on PRs from forks because it fails.

dhruvkb · 2023-03-11T07:41:54Z

I have to ask why the job is a part of the ci_cd.yml workflow? Wouldn't the label_new_pr.yml workflow, which calls the label_pr.yml workflow, which runs the label_pr.py script apply the label to the PRs automatically?

zackkrida · 2023-03-13T16:01:18Z

@dhruvkb I think that question is best answered by @AetherUnbound and we should probably get clarification on that before moving forward here.

AetherUnbound · 2023-03-13T20:59:43Z

I added this note in the description of #786:

The PR adds the auto-stack-adding action to the ci_cd workflow; I was initially going to add it to the label_pr since I'm concerned about race conditions happening between the label_pr action and the stack-labeling step.

I'm not sure that assumption/issue still holds, and in fact we no longer need to call the label_new_pr workflow using a remote dispatch since they coexist in the same repo (@dhruvkb has helpfully made #897 for covering this effort). Let me take another look at this and see if those race conditions are a real concern. If anything we can merge this (plus the suggested fork fix) for now and rework this down the road so at least merges to main no longer fail on this step.

dhruvkb

Thanks @AetherUnbound for looking into it again. I should've been more careful reviewing #786. I'll approve and unblock this for now because it's a positive change nonetheless.

github-actions · 2023-03-14T00:38:28Z

Size Change: -281 B (0%)

Total Size: 876 kB

Filename	Size	Change
`./frontend/.nuxt/dist/client/235.js`	0 B	-273 B (removed)	🏆
`./frontend/.nuxt/dist/client/235.modern.js`	0 B	-278 B (removed)	🏆
`./frontend/.nuxt/dist/client/236.js`	0 B	-1.85 kB (removed)	🏆
`./frontend/.nuxt/dist/client/app.js`	142 kB	+343 B (0%)
`./frontend/.nuxt/dist/client/app.modern.js`	116 kB	+212 B (0%)
`./frontend/.nuxt/dist/client/commons/app.js`	87.7 kB	+10 B (0%)
`./frontend/.nuxt/dist/client/commons/app.modern.js`	78.1 kB	-19 B (0%)
`./frontend/.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/d219393b.js`	9.95 kB	+67 B (+1%)
`./frontend/.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/d219393b.modern.js`	9.93 kB	+72 B (+1%)
`./frontend/.nuxt/dist/client/components/v-sources-table.js`	16.2 kB	+134 B (+1%)
`./frontend/.nuxt/dist/client/components/v-sources-table.modern.js`	16.2 kB	+137 B (+1%)
`./frontend/.nuxt/dist/client/pages/preferences.js`	1.32 kB	+45 B (+4%)
`./frontend/.nuxt/dist/client/pages/preferences.modern.js`	1.32 kB	+54 B (+4%)
`./frontend/.nuxt/dist/client/runtime.js`	2.7 kB	-18 B (-1%)
`./frontend/.nuxt/dist/client/runtime.modern.js`	2.71 kB	-17 B (-1%)
`./frontend/.nuxt/dist/client/vendors/app.js`	63.2 kB	-651 B (-1%)
`./frontend/.nuxt/dist/client/vendors/app.modern.js`	62.3 kB	-655 B (-1%)
`./frontend/.nuxt/dist/client/232.js`	273 B	+273 B (new file)	🆕
`./frontend/.nuxt/dist/client/232.modern.js`	277 B	+277 B (new file)	🆕
`./frontend/.nuxt/dist/client/233.js`	1.85 kB	+1.85 kB (new file)	🆕

ℹ️ View Unchanged

Filename	Size	Change
`./frontend/.nuxt/dist/client/components/loading-icon.js`	748 B	0 B
`./frontend/.nuxt/dist/client/components/loading-icon.modern.js`	753 B	0 B
`./frontend/.nuxt/dist/client/components/table-sort-icon.js`	514 B	0 B
`./frontend/.nuxt/dist/client/components/table-sort-icon.modern.js`	519 B	0 B
`./frontend/.nuxt/dist/client/components/v-all-results-grid.js`	8.01 kB	0 B
`./frontend/.nuxt/dist/client/components/v-all-results-grid.modern.js`	5.49 kB	0 B
`./frontend/.nuxt/dist/client/components/v-audio-cell.js`	390 B	0 B
`./frontend/.nuxt/dist/client/components/v-audio-cell.modern.js`	395 B	0 B
`./frontend/.nuxt/dist/client/components/v-audio-details.js`	2.55 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-audio-details.modern.js`	1.79 kB	0 B
`./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.js`	1.02 kB	0 B
`./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.modern.js`	1.02 kB	0 B
`./frontend/.nuxt/dist/client/components/v-audio-track.js`	5.23 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-audio-track.modern.js`	5.17 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.js`	542 B	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.modern.js`	548 B	0 B
`./frontend/.nuxt/dist/client/components/v-bone.js`	692 B	0 B
`./frontend/.nuxt/dist/client/components/v-bone.modern.js`	695 B	0 B
`./frontend/.nuxt/dist/client/components/v-box-layout.js`	1.24 kB	0 B
`./frontend/.nuxt/dist/client/components/v-box-layout.modern.js`	1.24 kB	0 B
`./frontend/.nuxt/dist/client/components/v-content-link.js`	1.12 kB	0 B
`./frontend/.nuxt/dist/client/components/v-content-link.modern.js`	1.1 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-content-page.js`	526 B	0 B
`./frontend/.nuxt/dist/client/components/v-content-page.modern.js`	530 B	0 B
`./frontend/.nuxt/dist/client/components/v-content-report-button.js`	786 B	0 B
`./frontend/.nuxt/dist/client/components/v-content-report-button.modern.js`	787 B	0 B
`./frontend/.nuxt/dist/client/components/v-content-report-form.js`	6.11 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-content-report-form.modern.js`	3.59 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-content-report-popover.js`	1.24 kB	0 B
`./frontend/.nuxt/dist/client/components/v-content-report-popover.modern.js`	4.25 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-copy-button.js`	4 kB	0 B
`./frontend/.nuxt/dist/client/components/v-copy-button.modern.js`	4.01 kB	0 B
`./frontend/.nuxt/dist/client/components/v-copy-license.js`	1 kB	0 B
`./frontend/.nuxt/dist/client/components/v-copy-license.modern.js`	1 kB	0 B
`./frontend/.nuxt/dist/client/components/v-dmca-notice.js`	753 B	0 B
`./frontend/.nuxt/dist/client/components/v-dmca-notice.modern.js`	757 B	0 B
`./frontend/.nuxt/dist/client/components/v-error-image.js`	1.7 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-error-image.modern.js`	1.69 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-error-section.js`	372 B	0 B
`./frontend/.nuxt/dist/client/components/v-error-section.modern.js`	376 B	0 B
`./frontend/.nuxt/dist/client/components/v-external-search-form.js`	1.92 kB	0 B
`./frontend/.nuxt/dist/client/components/v-external-search-form.modern.js`	1.92 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-external-source-list.js`	903 B	-2 B (0%)
`./frontend/.nuxt/dist/client/components/v-external-source-list.modern.js`	906 B	0 B
`./frontend/.nuxt/dist/client/components/v-full-layout.js`	1.52 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-full-layout.modern.js`	1.52 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/components/v-grid-skeleton.js`	1.62 kB	0 B
`./frontend/.nuxt/dist/client/components/v-grid-skeleton.modern.js`	1.63 kB	0 B
`./frontend/.nuxt/dist/client/components/v-home-gallery.js`	4.8 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/components/v-home-gallery.modern.js`	4.79 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-homepage-content.js`	1.76 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-homepage-content.modern.js`	1.73 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/components/v-image-carousel.js`	4.73 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/components/v-image-carousel.modern.js`	4.7 kB	0 B
`./frontend/.nuxt/dist/client/components/v-image-cell.js`	1.57 kB	0 B
`./frontend/.nuxt/dist/client/components/v-image-cell.modern.js`	1.56 kB	0 B
`./frontend/.nuxt/dist/client/components/v-image-details.js`	2.17 kB	0 B
`./frontend/.nuxt/dist/client/components/v-image-details.modern.js`	1.43 kB	0 B
`./frontend/.nuxt/dist/client/components/v-image-grid.js`	5 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-image-grid.modern.js`	2.52 kB	0 B
`./frontend/.nuxt/dist/client/components/v-license-tab-panel.js`	526 B	0 B
`./frontend/.nuxt/dist/client/components/v-license-tab-panel.modern.js`	529 B	0 B
`./frontend/.nuxt/dist/client/components/v-load-more.js`	3.17 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-load-more.modern.js`	696 B	0 B
`./frontend/.nuxt/dist/client/components/v-media-license.js`	827 B	0 B
`./frontend/.nuxt/dist/client/components/v-media-license.modern.js`	836 B	0 B
`./frontend/.nuxt/dist/client/components/v-media-reuse.js`	1.63 kB	0 B
`./frontend/.nuxt/dist/client/components/v-media-reuse.modern.js`	1.63 kB	0 B
`./frontend/.nuxt/dist/client/components/v-media-tag.js`	434 B	0 B
`./frontend/.nuxt/dist/client/components/v-media-tag.modern.js`	438 B	0 B
`./frontend/.nuxt/dist/client/components/v-modal.js`	1.01 kB	0 B
`./frontend/.nuxt/dist/client/components/v-modal.modern.js`	995 B	0 B
`./frontend/.nuxt/dist/client/components/v-no-results.js`	756 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-no-results.modern.js`	760 B	0 B
`./frontend/.nuxt/dist/client/components/v-radio.js`	1.51 kB	0 B
`./frontend/.nuxt/dist/client/components/v-radio.modern.js`	1.47 kB	0 B
`./frontend/.nuxt/dist/client/components/v-related-audio.js`	1.26 kB	0 B
`./frontend/.nuxt/dist/client/components/v-related-audio.modern.js`	1.27 kB	0 B
`./frontend/.nuxt/dist/client/components/v-related-images.js`	1.06 kB	0 B
`./frontend/.nuxt/dist/client/components/v-related-images.modern.js`	3.1 kB	0 B
`./frontend/.nuxt/dist/client/components/v-report-desc-form.js`	978 B	0 B
`./frontend/.nuxt/dist/client/components/v-report-desc-form.modern.js`	981 B	0 B
`./frontend/.nuxt/dist/client/components/v-row-layout.js`	1.71 kB	0 B
`./frontend/.nuxt/dist/client/components/v-row-layout.modern.js`	1.72 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-scroll-button.js`	824 B	0 B
`./frontend/.nuxt/dist/client/components/v-scroll-button.modern.js`	830 B	0 B
`./frontend/.nuxt/dist/client/components/v-search-grid.js`	5.76 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-search-grid.modern.js`	5.68 kB	0 B
`./frontend/.nuxt/dist/client/components/v-search-results-title.js`	599 B	0 B
`./frontend/.nuxt/dist/client/components/v-search-results-title.modern.js`	604 B	0 B
`./frontend/.nuxt/dist/client/components/v-search-type-radio.js`	806 B	+1 B (0%)
`./frontend/.nuxt/dist/client/components/v-search-type-radio.modern.js`	781 B	+2 B (0%)
`./frontend/.nuxt/dist/client/components/v-server-timeout.js`	299 B	0 B
`./frontend/.nuxt/dist/client/components/v-server-timeout.modern.js`	303 B	0 B
`./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.js`	3.4 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js`	913 B	0 B
`./frontend/.nuxt/dist/client/components/v-snackbar.js`	1.19 kB	0 B
`./frontend/.nuxt/dist/client/components/v-snackbar.modern.js`	1.19 kB	0 B
`./frontend/.nuxt/dist/client/components/v-warning-suppressor.js`	306 B	0 B
`./frontend/.nuxt/dist/client/components/v-warning-suppressor.modern.js`	311 B	0 B
`./frontend/.nuxt/dist/client/pages/about.js`	1.4 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/pages/about.modern.js`	1.4 kB	0 B
`./frontend/.nuxt/dist/client/pages/audio/_id/index.js`	8.02 kB	-3 B (0%)
`./frontend/.nuxt/dist/client/pages/audio/_id/index.modern.js`	4.85 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/pages/external-sources.js`	1.56 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/pages/external-sources.modern.js`	1.56 kB	0 B
`./frontend/.nuxt/dist/client/pages/feedback.js`	1.34 kB	0 B
`./frontend/.nuxt/dist/client/pages/feedback.modern.js`	1.34 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/pages/image/_id/index.js`	9.32 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/pages/image/_id/index.modern.js`	5.18 kB	-2 B (0%)
`./frontend/.nuxt/dist/client/pages/image/_id/report.js`	3.65 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/pages/image/_id/report.modern.js`	4.26 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/pages/index.js`	6.9 kB	-2 B (0%)
`./frontend/.nuxt/dist/client/pages/index.modern.js`	6.83 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/pages/privacy.js`	1.01 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/pages/privacy.modern.js`	1.02 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/pages/search-help.js`	1.6 kB	0 B
`./frontend/.nuxt/dist/client/pages/search-help.modern.js`	1.58 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/pages/search.js`	4.56 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/pages/search.modern.js`	2.04 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/pages/search/audio.js`	6.03 kB	+2 B (0%)
`./frontend/.nuxt/dist/client/pages/search/audio.modern.js`	3.54 kB	0 B
`./frontend/.nuxt/dist/client/pages/search/image.js`	507 B	0 B
`./frontend/.nuxt/dist/client/pages/search/image.modern.js`	2.71 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/pages/search/index.js`	443 B	0 B
`./frontend/.nuxt/dist/client/pages/search/index.modern.js`	447 B	-1 B (0%)
`./frontend/.nuxt/dist/client/pages/search/model-3d.js`	243 B	0 B
`./frontend/.nuxt/dist/client/pages/search/model-3d.modern.js`	247 B	+1 B (0%)
`./frontend/.nuxt/dist/client/pages/search/search-page.types.js`	266 B	0 B
`./frontend/.nuxt/dist/client/pages/search/search-page.types.modern.js`	271 B	+1 B (0%)
`./frontend/.nuxt/dist/client/pages/search/video.js`	240 B	0 B
`./frontend/.nuxt/dist/client/pages/search/video.modern.js`	244 B	+1 B (0%)
`./frontend/.nuxt/dist/client/pages/sources.js`	1.57 kB	+1 B (0%)
`./frontend/.nuxt/dist/client/pages/sources.modern.js`	1.57 kB	-1 B (0%)

_{compressed-size-action}

github-actions · 2023-03-14T00:42:40Z

Playwright failure test results

It looks like some of the Playwright tests failed. You can download the Playwright trace
output for all playwright tests that have failed at the bottom of this page, under the
"Artifacts" section:

https://github.com/WordPress/openverse/actions/runs/4410892173

Read more about how to use this artifact here: https://github.com/WordPress/openverse/blob/main/frontend/test/playwright/README.md#debugging

AetherUnbound · 2023-03-30T20:01:56Z

Okay I had some time to look into this today and I'm not sure how we could change this without making it overly complicated. The "add stack label" step currently in ci_cd.yml relies on get-changes, which is specific to the monorepo. The label_pr.yml workflow which is dispatched from all of our repos is agnostic to which repo it's working on. Thus it would be harder for us to add the stack labeling to the label PR step because get-changes wouldn't always be available. We could allow it as a parameter to the script similar to PR_URL, but then we'd need to add logic to the script to be able to process that input and add the necessary label. So I think keeping this in ci_cd.yml is easiest for now, since this is a monorepo-specific action and the ci_cd.yml workflow is monorepo-specific.

Only run stack label addition step on pull requests

d4b1668

AetherUnbound added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 🤖 aspect: dx Concerns developers' experience with the codebase 🧱 stack: mgmt Related to repo management and automations labels Mar 9, 2023

github-actions bot added 🧱 stack: api Related to the Django API 🧱 stack: ingestion server Related to the ingestion/data refresh server 🧱 stack: frontend Related to the Nuxt frontend labels Mar 9, 2023

obulat assigned AetherUnbound Mar 10, 2023

obulat approved these changes Mar 10, 2023

View reviewed changes

dhruvkb reviewed Mar 11, 2023

View reviewed changes

dhruvkb approved these changes Mar 13, 2023

View reviewed changes

Make sure this is run on the correct repository

8e966be

AetherUnbound merged commit 8e9d23a into main Mar 14, 2023

AetherUnbound deleted the hotfix/stack-label-push-runs branch March 14, 2023 01:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Only run stack label addition step on pull requests #882

Only run stack label addition step on pull requests #882

Uh oh!

AetherUnbound commented Mar 9, 2023

Uh oh!

github-actions bot commented Mar 9, 2023 •

edited

Loading

Uh oh!

obulat left a comment

Uh oh!

dhruvkb left a comment

Uh oh!

dhruvkb commented Mar 11, 2023

Uh oh!

zackkrida commented Mar 13, 2023

Uh oh!

AetherUnbound commented Mar 13, 2023

Uh oh!

dhruvkb left a comment

Uh oh!

github-actions bot commented Mar 14, 2023

Uh oh!

github-actions bot commented Mar 14, 2023

Uh oh!

AetherUnbound commented Mar 30, 2023

Uh oh!

Uh oh!

Only run stack label addition step on pull requests #882

Only run stack label addition step on pull requests #882

Uh oh!

Conversation

AetherUnbound commented Mar 9, 2023

Description

Testing Instructions

Checklist

Developer Certificate of Origin

Uh oh!

github-actions bot commented Mar 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

obulat left a comment

Choose a reason for hiding this comment

Uh oh!

dhruvkb left a comment

Choose a reason for hiding this comment

Uh oh!

dhruvkb commented Mar 11, 2023

Uh oh!

zackkrida commented Mar 13, 2023

Uh oh!

AetherUnbound commented Mar 13, 2023

Uh oh!

dhruvkb left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 14, 2023

Uh oh!

github-actions bot commented Mar 14, 2023

Uh oh!

AetherUnbound commented Mar 30, 2023

Uh oh!

Uh oh!

github-actions bot commented Mar 9, 2023 •

edited

Loading