Skip to content

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Feb 10, 2025

Fixes

Fixes #5377 by @sentry-io

Description

This PR removes the usage of Head, Meta and Body components, which are causing problems when the comments are being hydrated.

Testing Instructions

Run the app and see that the comments are no longer in the body. The i18n-related meta and links should still be available, as well as the i18n properties on the html and body elements.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner February 10, 2025 15:35
@obulat obulat requested review from krysal and dhruvkb February 10, 2025 15:35
@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Feb 10, 2025
Copy link

github-actions bot commented Feb 10, 2025

Latest k6 run output1

     ✓ status was 200

     checks.........................: 100.00% ✓ 392      ✗ 0   
     data_received..................: 93 MB   388 kB/s
     data_sent......................: 51 kB   214 B/s
     http_req_blocked...............: avg=59.33µs  min=2.29µs   med=4.47µs   max=2.19ms   p(90)=153.39µs p(95)=253.01µs
     http_req_connecting............: avg=36.84µs  min=0s       med=0s       max=2.14ms   p(90)=101.79µs p(95)=158.46µs
     http_req_duration..............: avg=160.26ms min=16.3ms   med=110.26ms max=932.79ms p(90)=370.3ms  p(95)=448.62ms
       { expected_response:true }...: avg=160.26ms min=16.3ms   med=110.26ms max=932.79ms p(90)=370.3ms  p(95)=448.62ms
   ✓ http_req_failed................: 0.00%   ✓ 0        ✗ 392 
     http_req_receiving.............: avg=170.7µs  min=64.97µs  med=145.04µs max=873.88µs p(90)=258.41µs p(95)=349.09µs
     http_req_sending...............: avg=28.37µs  min=7.39µs   med=21.98µs  max=1.24ms   p(90)=42.06µs  p(95)=51.53µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=160.06ms min=16.18ms  med=110.11ms max=932.21ms p(90)=370.07ms p(95)=448.32ms
     http_reqs......................: 392     1.630593/s
     iteration_duration.............: avg=855.8ms  min=202.02ms med=927.44ms max=1.69s    p(90)=1.13s    p(95)=1.47s   
     iterations.....................: 74      0.307816/s
     vus............................: 0       min=0      max=6 
     vus_max........................: 60      min=60     max=60

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

@obulat obulat force-pushed the fix/seo-properties branch from 1da52da to 1106e36 Compare February 11, 2025 10:57
@obulat obulat merged commit 8c22021 into main Feb 13, 2025
48 checks passed
@obulat obulat deleted the fix/seo-properties branch February 13, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'slice')
3 participants