Skip to content

Add CNAME in other use of actions-gh-pages #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2023
Merged

Add CNAME in other use of actions-gh-pages #1006

merged 1 commit into from
Mar 24, 2023

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Mar 23, 2023

Description

This PR adds the CNAME to the peaceiris/actions-gh-pages usage that was lacking it. The intention is the same as #1005.

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 🤖 aspect: dx Concerns developers' experience with the codebase 🧱 stack: mgmt Related to repo management and automations labels Mar 23, 2023
@dhruvkb dhruvkb requested a review from a team as a code owner March 23, 2023 16:41
@github-actions github-actions bot added 🧱 stack: api Related to the Django API 🧱 stack: ingestion server Related to the ingestion/data refresh server 🧱 stack: frontend Related to the Nuxt frontend labels Mar 23, 2023
@github-actions
Copy link

Size Change: 0 B

Total Size: 848 kB

ℹ️ View Unchanged
Filename Size
./frontend/.nuxt/dist/client/235.js 273 B
./frontend/.nuxt/dist/client/235.modern.js 278 B
./frontend/.nuxt/dist/client/236.js 1.85 kB
./frontend/.nuxt/dist/client/app.js 125 kB
./frontend/.nuxt/dist/client/app.modern.js 117 kB
./frontend/.nuxt/dist/client/commons/app.js 90.3 kB
./frontend/.nuxt/dist/client/commons/app.modern.js 78.5 kB
./frontend/.nuxt/dist/client/components/loading-icon.js 750 B
./frontend/.nuxt/dist/client/components/loading-icon.modern.js 757 B
./frontend/.nuxt/dist/client/components/table-sort-icon.js 515 B
./frontend/.nuxt/dist/client/components/table-sort-icon.modern.js 518 B
./frontend/.nuxt/dist/client/components/v-all-results-grid.js 5.63 kB
./frontend/.nuxt/dist/client/components/v-all-results-grid.modern.js 5.48 kB
./frontend/.nuxt/dist/client/components/v-audio-cell.js 392 B
./frontend/.nuxt/dist/client/components/v-audio-cell.modern.js 397 B
./frontend/.nuxt/dist/client/components/v-audio-details.js 1.83 kB
./frontend/.nuxt/dist/client/components/v-audio-details.modern.js 1.8 kB
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.js 1.01 kB
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.modern.js 1.02 kB
./frontend/.nuxt/dist/client/components/v-audio-track.js 5.25 kB
./frontend/.nuxt/dist/client/components/v-audio-track.modern.js 5.21 kB
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.js 542 B
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.modern.js 548 B
./frontend/.nuxt/dist/client/components/v-bone.js 688 B
./frontend/.nuxt/dist/client/components/v-bone.modern.js 693 B
./frontend/.nuxt/dist/client/components/v-box-layout.js 1.28 kB
./frontend/.nuxt/dist/client/components/v-box-layout.modern.js 1.27 kB
./frontend/.nuxt/dist/client/components/v-content-link.js 1.12 kB
./frontend/.nuxt/dist/client/components/v-content-link.modern.js 1.1 kB
./frontend/.nuxt/dist/client/components/v-content-page.js 526 B
./frontend/.nuxt/dist/client/components/v-content-page.modern.js 530 B
./frontend/.nuxt/dist/client/components/v-content-report-button.js 784 B
./frontend/.nuxt/dist/client/components/v-content-report-button.modern.js 789 B
./frontend/.nuxt/dist/client/components/v-content-report-form.js 3.78 kB
./frontend/.nuxt/dist/client/components/v-content-report-form.modern.js 3.6 kB
./frontend/.nuxt/dist/client/components/v-content-report-popover.js 4.44 kB
./frontend/.nuxt/dist/client/components/v-content-report-popover.modern.js 4.25 kB
./frontend/.nuxt/dist/client/components/v-copy-button.js 4 kB
./frontend/.nuxt/dist/client/components/v-copy-button.modern.js 4.01 kB
./frontend/.nuxt/dist/client/components/v-copy-license.js 1 kB
./frontend/.nuxt/dist/client/components/v-copy-license.modern.js 1.01 kB
./frontend/.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/d219393b.js 9.96 kB
./frontend/.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/d219393b.modern.js 9.94 kB
./frontend/.nuxt/dist/client/components/v-dmca-notice.js 754 B
./frontend/.nuxt/dist/client/components/v-dmca-notice.modern.js 759 B
./frontend/.nuxt/dist/client/components/v-error-image.js 1.7 kB
./frontend/.nuxt/dist/client/components/v-error-image.modern.js 1.68 kB
./frontend/.nuxt/dist/client/components/v-error-section.js 372 B
./frontend/.nuxt/dist/client/components/v-error-section.modern.js 376 B
./frontend/.nuxt/dist/client/components/v-external-search-form.js 1.93 kB
./frontend/.nuxt/dist/client/components/v-external-search-form.modern.js 1.92 kB
./frontend/.nuxt/dist/client/components/v-external-source-list.js 906 B
./frontend/.nuxt/dist/client/components/v-external-source-list.modern.js 907 B
./frontend/.nuxt/dist/client/components/v-full-layout.js 1.52 kB
./frontend/.nuxt/dist/client/components/v-full-layout.modern.js 1.52 kB
./frontend/.nuxt/dist/client/components/v-grid-skeleton.js 1.61 kB
./frontend/.nuxt/dist/client/components/v-grid-skeleton.modern.js 1.62 kB
./frontend/.nuxt/dist/client/components/v-home-gallery.js 5.19 kB
./frontend/.nuxt/dist/client/components/v-home-gallery.modern.js 5.17 kB
./frontend/.nuxt/dist/client/components/v-homepage-content.js 1.76 kB
./frontend/.nuxt/dist/client/components/v-homepage-content.modern.js 1.73 kB
./frontend/.nuxt/dist/client/components/v-image-carousel.js 4.74 kB
./frontend/.nuxt/dist/client/components/v-image-carousel.modern.js 4.71 kB
./frontend/.nuxt/dist/client/components/v-image-cell.js 1.59 kB
./frontend/.nuxt/dist/client/components/v-image-cell.modern.js 1.59 kB
./frontend/.nuxt/dist/client/components/v-image-details.js 1.44 kB
./frontend/.nuxt/dist/client/components/v-image-details.modern.js 1.43 kB
./frontend/.nuxt/dist/client/components/v-image-grid.js 2.66 kB
./frontend/.nuxt/dist/client/components/v-image-grid.modern.js 2.54 kB
./frontend/.nuxt/dist/client/components/v-license-tab-panel.js 526 B
./frontend/.nuxt/dist/client/components/v-license-tab-panel.modern.js 530 B
./frontend/.nuxt/dist/client/components/v-load-more.js 798 B
./frontend/.nuxt/dist/client/components/v-load-more.modern.js 697 B
./frontend/.nuxt/dist/client/components/v-media-license.js 829 B
./frontend/.nuxt/dist/client/components/v-media-license.modern.js 837 B
./frontend/.nuxt/dist/client/components/v-media-reuse.js 1.63 kB
./frontend/.nuxt/dist/client/components/v-media-reuse.modern.js 1.63 kB
./frontend/.nuxt/dist/client/components/v-media-tag.js 434 B
./frontend/.nuxt/dist/client/components/v-media-tag.modern.js 438 B
./frontend/.nuxt/dist/client/components/v-modal.js 1.01 kB
./frontend/.nuxt/dist/client/components/v-modal.modern.js 996 B
./frontend/.nuxt/dist/client/components/v-no-results.js 756 B
./frontend/.nuxt/dist/client/components/v-no-results.modern.js 755 B
./frontend/.nuxt/dist/client/components/v-radio.js 1.52 kB
./frontend/.nuxt/dist/client/components/v-radio.modern.js 1.48 kB
./frontend/.nuxt/dist/client/components/v-related-audio.js 1.26 kB
./frontend/.nuxt/dist/client/components/v-related-audio.modern.js 1.27 kB
./frontend/.nuxt/dist/client/components/v-related-images.js 3.24 kB
./frontend/.nuxt/dist/client/components/v-related-images.modern.js 3.12 kB
./frontend/.nuxt/dist/client/components/v-report-desc-form.js 977 B
./frontend/.nuxt/dist/client/components/v-report-desc-form.modern.js 979 B
./frontend/.nuxt/dist/client/components/v-row-layout.js 1.71 kB
./frontend/.nuxt/dist/client/components/v-row-layout.modern.js 1.71 kB
./frontend/.nuxt/dist/client/components/v-scroll-button.js 824 B
./frontend/.nuxt/dist/client/components/v-scroll-button.modern.js 830 B
./frontend/.nuxt/dist/client/components/v-search-grid.js 5.75 kB
./frontend/.nuxt/dist/client/components/v-search-grid.modern.js 5.67 kB
./frontend/.nuxt/dist/client/components/v-search-results-title.js 598 B
./frontend/.nuxt/dist/client/components/v-search-results-title.modern.js 605 B
./frontend/.nuxt/dist/client/components/v-search-type-radio.js 805 B
./frontend/.nuxt/dist/client/components/v-search-type-radio.modern.js 779 B
./frontend/.nuxt/dist/client/components/v-server-timeout.js 300 B
./frontend/.nuxt/dist/client/components/v-server-timeout.modern.js 303 B
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.js 1.01 kB
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js 913 B
./frontend/.nuxt/dist/client/components/v-snackbar.js 1.16 kB
./frontend/.nuxt/dist/client/components/v-snackbar.modern.js 1.16 kB
./frontend/.nuxt/dist/client/components/v-sources-table.js 15 kB
./frontend/.nuxt/dist/client/components/v-sources-table.modern.js 15 kB
./frontend/.nuxt/dist/client/components/v-warning-suppressor.js 306 B
./frontend/.nuxt/dist/client/components/v-warning-suppressor.modern.js 311 B
./frontend/.nuxt/dist/client/pages/about.js 1.4 kB
./frontend/.nuxt/dist/client/pages/about.modern.js 1.4 kB
./frontend/.nuxt/dist/client/pages/audio/_id/index.js 5.02 kB
./frontend/.nuxt/dist/client/pages/audio/_id/index.modern.js 4.87 kB
./frontend/.nuxt/dist/client/pages/external-sources.js 1.56 kB
./frontend/.nuxt/dist/client/pages/external-sources.modern.js 1.57 kB
./frontend/.nuxt/dist/client/pages/feedback.js 1.34 kB
./frontend/.nuxt/dist/client/pages/feedback.modern.js 1.35 kB
./frontend/.nuxt/dist/client/pages/image/_id/index.js 5.41 kB
./frontend/.nuxt/dist/client/pages/image/_id/index.modern.js 5.17 kB
./frontend/.nuxt/dist/client/pages/image/_id/report.js 4.55 kB
./frontend/.nuxt/dist/client/pages/image/_id/report.modern.js 4.27 kB
./frontend/.nuxt/dist/client/pages/index.js 7.28 kB
./frontend/.nuxt/dist/client/pages/index.modern.js 7.21 kB
./frontend/.nuxt/dist/client/pages/preferences.js 1.32 kB
./frontend/.nuxt/dist/client/pages/preferences.modern.js 1.32 kB
./frontend/.nuxt/dist/client/pages/privacy.js 1.01 kB
./frontend/.nuxt/dist/client/pages/privacy.modern.js 1.02 kB
./frontend/.nuxt/dist/client/pages/search-help.js 1.6 kB
./frontend/.nuxt/dist/client/pages/search-help.modern.js 1.58 kB
./frontend/.nuxt/dist/client/pages/search.js 2.2 kB
./frontend/.nuxt/dist/client/pages/search.modern.js 2.04 kB
./frontend/.nuxt/dist/client/pages/search/audio.js 3.59 kB
./frontend/.nuxt/dist/client/pages/search/audio.modern.js 3.5 kB
./frontend/.nuxt/dist/client/pages/search/image.js 2.84 kB
./frontend/.nuxt/dist/client/pages/search/image.modern.js 2.73 kB
./frontend/.nuxt/dist/client/pages/search/index.js 443 B
./frontend/.nuxt/dist/client/pages/search/index.modern.js 448 B
./frontend/.nuxt/dist/client/pages/search/model-3d.js 243 B
./frontend/.nuxt/dist/client/pages/search/model-3d.modern.js 246 B
./frontend/.nuxt/dist/client/pages/search/search-page.types.js 266 B
./frontend/.nuxt/dist/client/pages/search/search-page.types.modern.js 271 B
./frontend/.nuxt/dist/client/pages/search/video.js 240 B
./frontend/.nuxt/dist/client/pages/search/video.modern.js 244 B
./frontend/.nuxt/dist/client/pages/sources.js 1.57 kB
./frontend/.nuxt/dist/client/pages/sources.modern.js 1.57 kB
./frontend/.nuxt/dist/client/runtime.js 2.72 kB
./frontend/.nuxt/dist/client/runtime.modern.js 2.73 kB
./frontend/.nuxt/dist/client/vendors/app.js 64.1 kB
./frontend/.nuxt/dist/client/vendors/app.modern.js 63.3 kB

compressed-size-action

zackkrida
zackkrida approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for missing this, thanks!

@github-actions
Copy link

github-actions bot commented Mar 23, 2023 •
edited
Loading

Full-stack documentation: Ready

https://WordPress.github.io/openverse/_preview/1006

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@dhruvkb dhruvkb merged commit f33c89f into main Mar 24, 2023
@dhruvkb dhruvkb deleted the missing_cname branch March 24, 2023 05:44
@obulat obulat added 🧱 stack: documentation Related to Sphinx documentation and removed 🧱 stack: api Related to the Django API 🧱 stack: frontend Related to the Nuxt frontend 🧱 stack: ingestion server Related to the ingestion/data refresh server labels Apr 13, 2023
dhruvkb pushed a commit that referenced this pull request Apr 14, 2023
@AetherUnbound @stacimc
Preserve trailing slashes for WordPress URLs (#1006)
9d758e9 
* Move URL validation step up to media store metadata cleaning

* Update tests to account for cleaning change

* Pass trailing slash removal into store class, add tests

* Update WordPress to preserve trailing slashes

* Add docs

* Spelling fix

Co-authored-by: Staci Mullins <[email protected]>

---------

Co-authored-by: Staci Mullins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zackkrida zackkrida zackkrida approved these changes

@AetherUnbound AetherUnbound AetherUnbound approved these changes

@stacimc stacimc stacimc approved these changes

Assignees
No one assigned
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: documentation Related to Sphinx documentation 🧱 stack: mgmt Related to repo management and automations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dhruvkb @zackkrida @AetherUnbound @stacimc @obulat