Remove useBlockDisplayTitle from BlockSwitcher #72608
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
useBlockDisplayTitle created two subscriptions and was running everytime content length changed. The main reason to use that hook is if you need to display the custom block title, which we don't. So, by switching to match?.title and blockType.title, we remove two subscriptions that were firing many times each keystroke in order to get a label for a button that isn't changing.
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +25 B (0%) Total Size: 2.19 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 20d0c96. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18730717152
|
|
It does bother me that we have two subscriptions for every block in |
|
The |
Mamaduka
reviewed
Oct 23, 2025
Comment on lines
+237
to
+244
| // For BlockSwitcher, we only show the block type or variation name | ||
| // We don't need custom labels (metadata.name) - those are only for list view | ||
| _blockTitle = match?.title || blockType.title; | ||
|
|
||
| // Truncate if needed (max 35 chars) | ||
| if ( _blockTitle && _blockTitle.length > 35 ) { | ||
| _blockTitle = _blockTitle.slice( 0, 34 ) + '…'; | ||
| } |
There was a problem hiding this comment.
Logic doesn't account for all cases, like dynamic block titles.
Screenshot
There was a problem hiding this comment.
I agree this isn't the right change. I'd like it to be a fix within useBlockDisplayTitle. The architecture of needing two subscriptions that get retriggered on every keystroke to get a static title is bothersome to me 😅
There was a problem hiding this comment.
Sounds good. I tried to optimize it in the past (#58250), so I'm happy to review changes when they're ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useBlockDisplayTitle created two subscriptions and was running everytime content length changed. The main reason to use that hook is if you need to display the custom block title, which we don't. So, by switching to match?.title and blockType.title, we remove two subscriptions that were firing many times each keystroke in order to get a label for a button that isn't changing.
What?
Closes
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast