Fix: Unable to pin comment sidebar after unpinning #71386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashjawale
changed the title
yashjawale
changed the title
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
added
[Type] Bug
|
@yashjawale, can you rebase this branch on top of the latest trunk? That should resolve CI checks. |
yashjawale
requested review from
tellthemachines,
spacedmonkey,
ObliviousHarmony,
t-hamano,
desrosj,
ellatrix,
gziolo,
adamsilverstein,
talldan,
swissspidy,
oandregal,
ajitbohra,
peterwilsoncc,
ntwb,
nerrad,
ryanwelcher,
kevin940726,
luisherranz,
DAreRodz,
draganescu and
adamziel
as code owners
yashjawale
requested review from
dmsnell,
atimmer,
fabiankaegy,
mmtr,
juanmaguitar and
ndiego
as code owners
yashjawale
force-pushed
the
fix/block-comments-pinning
branch
from
43ebff7 to
0adcfa1
Compare
|
Apologies to everyone for pings 🙇♂️🙇♂️ |
Mamaduka
approved these changes
Sep 9, 2025
talldan
pushed a commit
that referenced
this pull request
Sep 10, 2025
…1386) Co-authored-by: yashjawale <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: adamsilverstein <[email protected]>
adamsilverstein
added a commit
to adamsilverstein/gutenberg
that referenced
this pull request
Sep 11, 2025
…rdPress#71386) Co-authored-by: yashjawale <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: adamsilverstein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #71377
This PR tries to resolve issue of not being able to pin the comments sidebar after unpinning it once
Previously, once the sidebar was unpinned, the icon/button disappeared from the toolbar and there was no intuitive way to restore it.
Why?
Pinning the Comments sidebar is a user setting and should be easily reversible.
How?
Interactions which open the Comments sidebar now activates pinnable sidebar
This ensures that the star button remains available for user to pin comment sidebar
Testing Instructions
Screenshots or screencast
Screen.Recording.2025-08-29.at.4.26.10.PM.mov