Skip to content

Conversation

dhruvikpatel18
Copy link
Contributor

@dhruvikpatel18 dhruvikpatel18 commented Aug 18, 2025

Followed PR of: #71204 (comment)

What?

This does seem like a good addition, similar to the Buttons block, and other design-related blocks such as Columns, Grid, and Group, which have an appender. The gallery block currently lacks one. so adding it would improve consistency.
If there’s enough consensus, should we raise a separate follow-up PR to address this?

By @im3dabasia

Screenshots or screencast

Before

Screenshot 2025-08-20 at 5 17 43 PM

After

Screenshot 2025-08-20 at 5 18 58 PM

@dhruvikpatel18 dhruvikpatel18 marked this pull request as ready for review August 18, 2025 11:10
Copy link

github-actions bot commented Aug 18, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dhruvikpatel18 <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: im3dabasia <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added [Type] Enhancement A suggestion for improvement. [Block] Gallery Affects the Gallery Block - used to display groups of images labels Aug 19, 2025
@Mamaduka Mamaduka added the Needs Design Feedback Needs general design feedback. label Aug 20, 2025
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, @dhruvikpatel18!

Can you include before/after screenshots for the PR.

Copy link
Contributor

@im3dabasia im3dabasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhruvikpatel18, when you have a moment, please rebase the PR with trunk so we can resolve the failing CI cases.

@Mamaduka
Copy link
Member

@dhruvikpatel18, @im3dabasia, let's get more feedback before merging this. I checked some old issues, and it seems that having "Add new" in the toolbar was intentional. See: #21247 and #38036.

While consistency is the key, not all blocks are created equal, and we should also keep that in mind.

@glendaviesnz, I know it's been a while since the Gallery block refactoring, but do you have any additional details?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants