-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Enabled default block appender in gallery edit component #71236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Enabled default block appender in gallery edit component #71236
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing, @dhruvikpatel18!
Can you include before/after screenshots for the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhruvikpatel18, when you have a moment, please rebase the PR with trunk so we can resolve the failing CI cases.
@dhruvikpatel18, @im3dabasia, let's get more feedback before merging this. I checked some old issues, and it seems that having "Add new" in the toolbar was intentional. See: #21247 and #38036. While consistency is the key, not all blocks are created equal, and we should also keep that in mind. @glendaviesnz, I know it's been a while since the Gallery block refactoring, but do you have any additional details? |
Followed PR of: #71204 (comment)
What?
By @im3dabasia
Screenshots or screencast
Before
After