Accordion Blocks: Make block icons internal #71229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
t-hamano
removed
the
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +6 B (0%) Total Size: 1.92 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in bac37c4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17003777826
|
|
@mikachan thanks for the review! |
adamsilverstein
pushed a commit
to adamsilverstein/gutenberg
that referenced
this pull request
Aug 20, 2025
Co-authored-by: t-hamano <[email protected]> Co-authored-by: mikachan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Accordion-related blocks are still experimental and subject to breaking changes. They are also unavailable unless explicitly enabled by users.
On the other hand, the icons are published in the icons package, so consumers are free to use them.
Since there is a possibility that the icon names will change or the icon designs will change significantly, I think it would be better not to release the icons until the accordion block is stable. Furthermore, these icons have limited use, so I'm not sure they're worth publishing.
Testing Instructions
Make sure the block icon is displayed as before.