Experiment: DataForm Modal Type #71212
Open
+599
−178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejolley
commented
Aug 14, 2025
mikejolley
commented
Aug 14, 2025
| @@ -258,9 +279,15 @@ const CombinedFieldsComponent = ( { | |||
| 'filesize', | |||
| 'dimensions', | |||
| 'tags', | |||
| { | |||
| id: 'combined_address', | |||
There was a problem hiding this comment.
Does it matter that this is a unique ID not defined in the post? We're generating the content from other values.
|
Size Change: +706 B (+0.04%) Total Size: 1.92 MB
ℹ️ View Unchanged
|
This is inconsistent with almost every other Modal instance. I’m not quite following the reasoning for disabling this behavior. When a modal has a dedicated close button (as is the case here) I think it’s reasonable to expect that clicking outside the modal will close it. |
jameskoster
reviewed
Aug 14, 2025
|
@jameskoster Does clicking outside of a modal "apply" or "cancel" changes? Apply would be safest to avoid discarding wanted changes. But its not explicit. |
|
I’d vote for consistency with other modals where clicking outside is the same as clicking close or cancel. |
mikejolley
force-pushed
the
experiment/dataform-modal
branch
from
b195587 to
e3e552e
Compare
|
@jameskoster I've added size |
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mikejolley
added
[Package] DataViews
|
Flaky tests detected in 181eeed. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/16993831021
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds a
modalpanel type. Enabled by settingpanelTypefromdropdowntomodal.On edit, controls are presented in a modal. There is local state to prevent onChange firing right away. onChange is triggered when you click the
applybutton. If you cancel or clickxchanges are discarded. Clicking outside of the modaldoes nothing as we want to user to use one of the CTAcancels any changes.On top of this, I wanted to include a way to control the data presented for combined fields so you can present a set of data in a unique way. I've included this example in Storybook:
This is a combined field made up of 3 simple fields with a custom
contentprop. When you edit this you see:Note some of this code was created by AI agent. I've reviewed and tweaked where appropriate. The
contentprop addition was hand coded.Why?
How?
contentpropTesting Instructions
?path=/story/dataviews-dataform--combined-fields&args=panelType:modal;labelPosition:top