-
Notifications
You must be signed in to change notification settings - Fork 4.7k
[RNMobile] Fix dictation regression on iOS #49452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
889a3c1
fix: Ensure dictated text is alway propagated
SiobhyB a5b67dc
Merge branch 'trunk' into rnmobile/fix/dictation-regression-ios
SiobhyB ec8e8a9
docs: Update CHANGELOG with details of fix
SiobhyB 4237064
docs: Fix CHANGELOG entry's grouping
SiobhyB 8157447
Merge branch 'trunk' into rnmobile/fix/dictation-regression-ios
SiobhyB fd2ef19
Merge branch 'trunk' into rnmobile/fix/dictation-regression-ios
SiobhyB 0416ca7
fix: Ensure objectPlaceholder is always replaced
SiobhyB 2df979a
Merge branch 'trunk' into rnmobile/fix/dictation-regression-ios
SiobhyB bc2a630
docs: Reformat/update CHANGELOG with fix details
SiobhyB 5debaec
reformat: Add new line at end of CHANGELOG file
SiobhyB 5409ec2
Merge branch 'trunk' into rnmobile/fix/dictation-regression-ios
SiobhyB 3a0d386
fix: Ensure text is added at cursor point
SiobhyB 84e527d
Revert "fix: Ensure text is added at cursor point"
SiobhyB 58e99e1
fix: Ensure text is added at cursor point
SiobhyB 96da5bc
Merge branch 'trunk' into rnmobile/fix/dictation-regression-ios
SiobhyB c4c40e0
fix: Ensure objectPlaceholder is always replaced
SiobhyB 316276d
refactor: Remove redundant code for replacing obj
SiobhyB ff0162a
refactor: Ensure obj symbol is always replaced
SiobhyB c832e82
refactor: Remove all dictation hacks
SiobhyB 7cd7a0f
fix: Prevent 'obj' being added following dictation
SiobhyB fe957c3
fix: Ensure cursor position is set after dictation
SiobhyB 88f5056
Merge branch 'trunk' into rnmobile/fix/dictation-regression-ios
SiobhyB ff64c55
refactor: Remove unwanted spacing
SiobhyB File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.