Skip to content

Conversation

merceyz
Copy link
Contributor

@merceyz merceyz commented Feb 7, 2024

According to #230 (comment) SQLITE_OMIT_GET_TABLE is set to reduce the binary size, by 4224 bytes in my test, but it causes the SpatiaLite extension to segfault the process.

This PR removes SQLITE_OMIT_GET_TABLE to support SpatiaLite.

Loading mod_spatialite works without this PR but SELECT InitSpatialMetaData() doesn't.

Ref #520

Copy link
Member

@mceachen mceachen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for adding the test, too!

@mceachen
Copy link
Member

mceachen commented Feb 8, 2024

@JoshuaWise when you have a chance, can you check this out please?

@JoshuaWise JoshuaWise merged commit 60763a0 into WiseLibs:master Feb 22, 2024
@merceyz merceyz deleted the merceyz/fix/spatialite-support branch February 22, 2024 22:45
ArGeoph pushed a commit to ArGeoph/better-sqlite3 that referenced this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants