Skip to content

Conversation

@LunarTwilight
Copy link
Contributor

thanks for pointing it out puxlit
Copy link
Member

@KockaAdmiralac KockaAdmiralac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the Node.js version in package.json and regenerate the lockfile? Does ESLint now successfully lint the file?

@LunarTwilight
Copy link
Contributor Author

LunarTwilight commented May 16, 2024

Can you update the Node.js version in package.json and regenerate the lockfile? Does ESLint now successfully lint the file?

Would it be better to submit that as a separate PR? So that way I can also update the NPM packages too. Or I could make this PR into more of a general PR, rather than doing a PR for each thing. (I was also thinking about changing

console.log(this._data);
to be a debug log instead too)

@KockaAdmiralac
Copy link
Member

KockaAdmiralac commented Jun 14, 2024

I mean, if this PR is bumping the required Node.js version, then this PR should be the one to update it and bump the version. You can bump the version again in a new PR if you're going to also update the packages.

@KockaAdmiralac KockaAdmiralac merged commit 30e34eb into master Jul 5, 2024
@KockaAdmiralac KockaAdmiralac deleted the LunarTwilight-patch-1 branch July 5, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants