[test] Remove unused minify_check helper.
#8128
Merged
+0
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last usage of this was removed in #6160. I'm assuming this was intentional and we didn't loose any coverage?
kripken
approved these changes
Dec 15, 2025
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
I think we decided that print-minified is not useful. We can probably remove that pass, unless I'm forgetting something...
Member
Author
|
Looks like |
Member
|
Oh, thanks, I forgot to look in the python test files... As the pass is tested, let's keep it. Maybe it has some use I am forgetting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last usage of this was removed in #6160. I'm assuming this was intentional and we didn't loose any coverage?