[Stack Switching] Fuzz Stack Switching #7834
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 444d8e0.
tlively
reviewed
Aug 15, 2025
src/tools/fuzzing/fuzzing.cpp
Outdated
| case HeapTypeKind::Cont: | ||
| WASM_UNREACHABLE("TODO: cont"); | ||
| case HeapTypeKind::Cont: { | ||
| auto funcType = Type(heapType.getContinuation().type, NonNullable); |
There was a problem hiding this comment.
Suggested change
| auto funcType = Type(heapType.getContinuation().type, NonNullable); | |
| auto funcType = Type(heapType.getContinuation().type, Nullable); |
There was a problem hiding this comment.
Nulls would just trap. But I guess we should cover that too. I can change this to use nulls rarely like we do elsewhere.
src/tools/fuzzing/fuzzing.cpp
Outdated
| WASM_UNREACHABLE("TODO: cont"); | ||
| case HeapTypeKind::Cont: { | ||
| auto funcType = Type(heapType.getContinuation().type, NonNullable); | ||
| return builder.makeContNew(heapType, makeRefFuncConst(funcType)); |
There was a problem hiding this comment.
Why not allow this to be an arbitrary expression with the expected type?
There was a problem hiding this comment.
Hmm, yeah, I don't think it could recurse in a bad way. I'll try that.
tlively
approved these changes
Aug 15, 2025
This reverts commit 8293638.
…ll when nullable..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
those from exception handling places.