Skip to content

Conversation

@kripken
Copy link
Member

@kripken kripken commented Aug 22, 2024

This constructed a LocalGraph, which computes the sets that reach each get. But
all we need to know is which params are live, so instead we can do a liveness
computation (which is just a boolean, not the list of sets). Also, it is simple to get
the liveness computation to only work on the parameters and not all the locals,
as a further optimization.

Existing tests cover this, though I did find that the case of unreachability needed
a new test.

On a large testcase I am looking at, this makes --dae 17% faster.

@kripken
Copy link
Member Author

kripken commented Aug 26, 2024

Fuzzed heavily over the weekend for any diff vs the previous behavior, no issues found.

@kripken kripken requested a review from tlively August 26, 2024 20:28
@kripken kripken merged commit 459bc07 into WebAssembly:main Aug 26, 2024
@kripken kripken deleted the param.cfg branch August 26, 2024 23:00
@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants