[FP16] Add a feature flag for FP16. #6864
Conversation
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
We should also update fuzzing.cpp to gate generation of the fp16 ops behind the feature flag.
| const char* MultiMemoryFeature = "multimemory"; | ||
| const char* TypedContinuationsFeature = "typed-continuations"; | ||
| const char* SharedEverythingFeature = "shared-everything"; | ||
| const char* FP16Feature = "fp16"; |
There was a problem hiding this comment.
Just to double check, does this match the feature name used by LLVM in the custom features section?
Preference for in this PR or follow up? |
|
Ideally in this one. Thanks! |
Ensure the "fp16" feature is enabled for FP16 instructions.
|
Added some fuzzing. FWW, I noticed we're missing relaxed simd support and splat instructions for floats. |
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
lgtm with fuzzing.
Side note, for incremental updates to a PR I would ask that we all try to use additional commits, rather than force-pushing a single commit. Incremental commits make incremental review easier, at least for me.
|
I try not to force push if I've rebased in upstream, but for small commits it seems the github "compare" link on the force pushes is as good as a separate commit. |
|
I guess the review UI is not on the compare link. I'll try to stick with separate commits. |
|
I wasn't aware of the "compare" button, thanks! Looks useful. But, yeah, it does seem to be missing the review UI, unfortunately, which commits do have. |
3 participants
Ensure the "fp16" feature is enabled for FP16 instructions.