fix null dereference in FunctionValidator::visitBlock validateCallParamsAndResult #6849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtb0x1
changed the title
tlively
reviewed
Aug 19, 2024
Member
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
Code looks good, but would you be able to add regression tests in test/lit/validation?
Contributor
Author
I added a regression test case, I am no expert of wast so this might be missing other variants. |
kripken
reviewed
Aug 26, 2024
Co-authored-by: Alon Zakai <[email protected]>
kripken
approved these changes
Aug 26, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #6847 and #6848