Add a TypeBuilder API for copying a heap type #6828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@kripken, I remember you suggested this recently. Do you remember where? |
tlively
force-pushed
the
type-builder-copy
branch
from
557138b to
d7e09b4
Compare
Member
Ah, I think that was here: #6798 (comment) |
kripken
reviewed
Aug 12, 2024
| // use it unmodified. | ||
| return type; | ||
| return typeBuilder.getTempRefType(ht, type.getNullability()); | ||
| } |
Member
There was a problem hiding this comment.
Did this code path change? Now it always calls getTempRefType, and I'm not sure why.
Member
Author
There was a problem hiding this comment.
It just simplifies the code a tiny bit to always create a temp type. I can undo this if you prefer; it has no bearing on correctness.
Member
There was a problem hiding this comment.
Is it not slower to create a temp type?
Member
Author
There was a problem hiding this comment.
I guess it does do more work compared to just returning the original type. Will revert.
Given a function that maps the old child heap types to new child heap types, the new API takes care of copying the rest of the structure of a given heap type into a TypeBuilder slot. Use the new API in GlobalTypeRewriter::rebuildTypes. It will also be used in an upcoming type optimization. This refactoring also required adding the ability to clear the supertype of a TypeBuilder slot, which was previously not possible.
tlively
force-pushed
the
type-builder-copy
branch
from
d7e09b4 to
392e83c
Compare
kripken
approved these changes
Aug 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a function that maps the old child heap types to new child heap
types, the new API takes care of copying the rest of the structure of a
given heap type into a TypeBuilder slot.
Use the new API in GlobalTypeRewriter::rebuildTypes. It will also be
used in an upcoming type optimization. This refactoring also required
adding the ability to clear the supertype of a TypeBuilder slot, which
was previously not possible.