[NFC] Add HeapType::isMaybeShared(BasicHeapType) utility #6773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Jul 18, 2024
tlively
force-pushed
the
threads-shared-fuzzing
branch
from
35c227f to
a6c1419
Compare
tlively
force-pushed
the
threads-maybe-shared-util
branch
from
ebe11c4 to
4cf7f52
Compare
tlively
force-pushed
the
threads-shared-fuzzing
branch
from
a6c1419 to
ec3bc3e
Compare
tlively
force-pushed
the
threads-maybe-shared-util
branch
from
4cf7f52 to
ee5fd0d
Compare
This abbreviates a common pattern where we first had to check whether a heap type was basic, then if it was, get its unshared version and compare it to some expected BasicHeapType. Suggested in #6771 (comment).
Co-authored-by: Alon Zakai <[email protected]>
tlively
force-pushed
the
threads-maybe-shared-util
branch
from
ee5fd0d to
531d6a7
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This abbreviates a common pattern where we first had to check whether a
heap type was basic, then if it was, get its unshared version and
compare it to some expected BasicHeapType.
Suggested in
#6771 (comment).