Skip to content

Conversation

@tlively
Copy link
Member

@tlively tlively commented Jun 25, 2024

Such as ref.eq, i31.get_{s,u}, and array.len. Also validate that
struct and array operations work on shared structs and arrays.

@tlively tlively requested a review from kripken June 25, 2024 02:04
Base automatically changed from shared-validation to main June 25, 2024 16:35
tlively added 3 commits June 25, 2024 09:37
Such as `ref.eq`, `i31.get_{s,u}`, and `array.len`. Also validate that
struct and array operations work on shared structs and arrays.
@tlively tlively force-pushed the threads-shared-polymorphism branch from 2c1d32c to d848bb7 Compare June 25, 2024 16:39
@tlively tlively merged commit 654ee6e into main Jun 25, 2024
@tlively tlively deleted the threads-shared-polymorphism branch June 25, 2024 19:39
@kripken
Copy link
Member

kripken commented Jun 26, 2024

I see fuzz errors after this landed, involving a file modified here, shared-array.wast. E.g. seed 15293465023328618278. If that doesn't reproduce on your machine @tlively you might see it by running the fuzzer for a short bit. If not then I can send you a full reproducer (I can't paste it here as it needs the binary input.dat file that the the fuzzer takes as input).

@kripken
Copy link
Member

kripken commented Jun 26, 2024

Ah, I realized I can just base64-encode it. Here:

https://gist.github.com/kripken/8e2fd08f2f95a7bfb0d5808e1a05a1fa

$ base64 -d input.dat.base64 > input.dat
$ bin/wasm-opt input.dat -ttf -all --disable-memory64 --disable-multivalue --closed-world --initial-fuzz=initial.wat

@tlively
Copy link
Member Author

tlively commented Jun 26, 2024

Yep, sorry about that. See #6706

@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants