Skip to content

Conversation

@kripken
Copy link
Member

@kripken kripken commented Jun 24, 2024

We tracked which expressions we saw an allocated struct/array reach, and then
quickly exited when another one did (as when two allocations mix, we can
optimize neither). It turns out that this helps very little in actual measurements
(looks like within noise - likely we are ruling out the un-optimizable cases early
otherwise anyhow). Also the complexity it adds is a problem for an improvement
I want to make to the pass, so remove it.

@kripken kripken requested a review from tlively June 24, 2024 23:45
@kripken kripken merged commit 4e07d86 into WebAssembly:main Jun 25, 2024
@kripken kripken deleted the heap2local.unopt branch June 25, 2024 16:05
@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants