Fix validation of unused LEB128 bits #6680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Jun 18, 2024
src/wasm-binary.h
Outdated
| : ((mask_type(1) << (sizeof(T) * 8 - shift)) - 1u); | ||
| T significant_payload = payload_mask & payload; | ||
| value |= significant_payload << shift; | ||
| T unused_bits_mask = ~payload_mask & 0x7F; |
Member
There was a problem hiding this comment.
We have 127 and 128 above, so perhaps replace 0x7F with that, or replace the above with hex?
tlively
force-pushed
the
spec-test-globals
branch
from
c8968e0 to
53f3d0f
Compare
tlively
force-pushed
the
spec-test-leb128
branch
from
782d30a to
c4bd0b4
Compare
The unused bits must be a sign extension of the significant value, but we were previously only validating that unsigned LEBs had their unused bytes set to zero. Re-enable the spec test that checks for proper validation.
tlively
force-pushed
the
spec-test-leb128
branch
from
c4bd0b4 to
5c8bd00
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unused bits must be a sign extension of the significant value, but we were
previously only validating that unsigned LEBs had their unused bytes set to
zero. Re-enable the spec test that checks for proper validation.