[threads] Binary reading and writing of shared composite types #6664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the BasicHeapTypes are in an enum, calling HeapType methods on them requires something like `HeapType(HeapType::func).someMethod()`. This is unnecessarily verbose, so add a new `HeapTypes` namespace that contains constexpr HeapType globals that can be used instead, shorting this to `HeapTypes::func.someMethod()`.
Also update the parser so that implicit type uses are not matched with shared function types.
kripken
approved these changes
Jun 14, 2024
test/lit/basic/shared-types.wast
Outdated
| ;; CHECK: (type $bot (sub final $mid (shared (struct (field i32) (field i32))))) | ||
| (type $bot (sub final $mid (shared (struct i32 i32)))) | ||
|
|
||
| (type $func (shared (func))) |
Member
There was a problem hiding this comment.
Can move this above to the CHECK.
Member
Author
There was a problem hiding this comment.
I'll use a rec group to get more control over the ordering.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update the parser so that implicit type uses are not matched with shared
function types.