Fix scratch local optimizations when emitting string slice #6649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The binary writing of `stringview_wtf16.slice` requires scratch locals to store the `start` and `end` operands while the string operand is converted to a stringview. To avoid unbounded binary bloat when round-tripping, we detect the case that `start` and `end` are already `local.get`s and avoid using scratch locals by deferring the binary writing of the `local.get` operands until after the stringview conversoins is emitted. We previously optimized the scratch locals for `start` and `end` independently, but this could produce incorrect code in the case where the `local.get` for `start` is deferred but its value is changed by a `local.set` in the code for `end`. Fix the problem by only optimizing to avoid scratch locals in the case where both `start` and `end` are already `local.get`s, so they will still be emitted in the original relative order and they cannot interfere with each other anyway.
kripken
approved these changes
Jun 11, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The binary writing of
stringview_wtf16.slicerequires scratch locals to store thestartandendoperands while the string operand is converted to a stringview. To avoid unbounded binary bloat when round-tripping, we detect the case thatstartandendare alreadylocal.gets and avoid using scratch locals by deferring the binary writing of thelocal.getoperands until after the stringview conversoins is emitted.We previously optimized the scratch locals for
startandendindependently, but this could produce incorrect code in the case where thelocal.getforstartis deferred but its value is changed by alocal.setin the code forend. Fix the problem by only optimizing to avoid scratch locals in the case where bothstartandendare alreadylocal.gets, so they will still be emitted in the original relative order and they cannot interfere with each other anyway.