Skip to content

[cmake] Remove redundant binaryen_emscripten_SOURCES #6602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
May 17, 2024
Merged

[cmake] Remove redundant binaryen_emscripten_SOURCES #6602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,14 +466,9 @@ endif()
# Note that SHELL: is needed as otherwise cmake will coalesce -s link flags
# in an incorrect way for emscripten.
if(EMSCRIPTEN)
set(binaryen_emscripten_SOURCES
src/binaryen-c.cpp
${binaryen_HEADERS}
)

# binaryen.js WebAssembly variant
add_executable(binaryen_wasm
${binaryen_emscripten_SOURCES})
${binaryen_SOURCES})
target_link_libraries(binaryen_wasm wasm asmjs emscripten-optimizer passes ir cfg support analysis parser wasm)
target_link_libraries(binaryen_wasm "-sFILESYSTEM")
target_link_libraries(binaryen_wasm "-sEXPORT_NAME=Binaryen")
Expand All @@ -498,7 +493,7 @@ if(EMSCRIPTEN)

# binaryen.js JavaScript variant
add_executable(binaryen_js
${binaryen_emscripten_SOURCES})
${binaryen_SOURCES})
target_link_libraries(binaryen_js wasm asmjs emscripten-optimizer passes ir cfg support analysis parser wasm)
target_link_libraries(binaryen_js "-sWASM=0")
target_link_libraries(binaryen_js "-sWASM_ASYNC_COMPILATION=0")
Expand Down