[EH] Rename option/pass names for new EH (exnref) #6592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We settled on the name `WASM_EXNREF` for the new setting in Emscripten for the name for the new EH option. https://github.com/emscripten-core/emscripten/blob/2bc5e3156f07e603bc4f3580cf84c038ea99b2df/src/settings.js#L782-L786 "New EH" sounds vague and I'm not sure if "experimental" is really necessary anyway, given that the potential users of this option is aware that this is a new spec that has been adopted recently. To make the option names consistent, this renames `--translate-to-eh` (the option that only runs the translator) to `--translate-to-exnref`, and `--experimental-new-eh` to `--emit-exnref` (the option that runs the translator at the end of the whole pipeline), and renames the pass and variable names in the code accordingly as well. In case anyone is using the old option names (and also to make the Chromium CI pass), this does not delete the old options.
aheejin
commented
May 15, 2024
| @@ -0,0 +1,28 @@ | |||
| ;; When given alone, --emit-exnref just runs --translate-to-exnref | |||
Member
Author
There was a problem hiding this comment.
This file has been moved from experimental-new_eh.wast. Not sure why it is not recognized as such.
tlively
approved these changes
May 15, 2024
kripken
approved these changes
May 15, 2024
Co-authored-by: Alon Zakai <[email protected]>
aheejin
added a commit
to aheejin/emscripten
that referenced
this pull request
May 15, 2024
This option was renamed in Binaryen to be consistent with the corresponding Emscripten option `-sWASM_EXNREF`: WebAssembly/binaryen#6592 The CI will pass once WebAssembly/binaryen#6592 passes the Chromium CI.
aheejin
added a commit
to emscripten-core/emscripten
that referenced
this pull request
May 16, 2024
This option was renamed in Binaryen to be consistent with the corresponding Emscripten option `-sWASM_EXNREF`: WebAssembly/binaryen#6592 The CI will pass once WebAssembly/binaryen#6592 passes the Chromium CI.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We settled on the name
WASM_EXNREFfor the new setting in Emscripten for the name for the new EH option.https://github.com/emscripten-core/emscripten/blob/2bc5e3156f07e603bc4f3580cf84c038ea99b2df/src/settings.js#L782-L786 "New EH" sounds vague and I'm not sure if "experimental" is really necessary anyway, given that the potential users of this option is aware that this is a new spec that has been adopted recently.
To make the option names consistent, this renames
--translate-to-eh(the option that only runs the translator) to--translate-to-exnref, and--experimental-new-ehto--emit-exnref(the option that runs the translator at the end of the whole pipeline), and renames the pass and variable names in the code accordingly as well.In case anyone is using the old option names (and also to make the Chromium CI pass), this does not delete the old options.