Skip to content

[NFC] Add printing for EffectAnalyzer #6586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kripken merged 3 commits into from
May 14, 2024
Merged

[NFC] Add printing for EffectAnalyzer #6586

kripken merged 3 commits into from
May 14, 2024

Conversation

@kripken
Copy link
Member

@kripken kripken commented May 13, 2024

With this you can do std::cout << effects and get something like

EffectAnalyzer{
  writesMemory
  hasSideEffects
}

@kripken kripken requested review from aheejin and tlively May 13, 2024 22:35
aheejin
aheejin approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@aheejin aheejin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very useful when debugging!

@kripken @aheejin
Update src/ir/effects.cpp
b706214 
Co-authored-by: Heejin Ahn <[email protected]>
@kripken kripken enabled auto-merge (squash) May 14, 2024 17:12
@kripken kripken merged commit 55f33b5 into WebAssembly:main May 14, 2024
@kripken kripken deleted the why.cse.2 branch May 14, 2024 18:00
@gkdn gkdn mentioned this pull request Aug 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tlively tlively tlively approved these changes

@aheejin aheejin aheejin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kripken @tlively @aheejin