[memory64] Add table64 to existing memory64 support #6577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
reviewed
May 9, 2024
tlively
reviewed
May 9, 2024
Member
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
Avoiding updating all the instructions at once sounds good if we can get away with it, but I'm concerned that the fuzzer will start failing without further fixes. Can you run it locally to check?
sbc100
force-pushed
the
table64
branch
2 times, most recently
from
860fb95 to
ff53669
Compare
Member
Author
|
Update all the table instructions now, and copied the tests from the memory64 proposal. I had to comment out the lines that use |
sbc100
force-pushed
the
table64
branch
2 times, most recently
from
c7d0736 to
1f20306
Compare
Tests is still very limited. Hopefully we can use the upstream spec tests soon and avoid having to write our own tests for `.set/.set/.fill/etc`. See WebAssembly/memory64#51
11 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See WebAssembly/memory64#51