Skip to content

GUFA: Handle bottom types in filterDataContents() #6545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 1 commit into from
Apr 25, 2024
Merged

GUFA: Handle bottom types in filterDataContents() #6545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/ir/possible-contents.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2616,7 +2616,13 @@ void Flower::filterGlobalContents(PossibleContents& contents,
void Flower::filterDataContents(PossibleContents& contents,
const DataLocation& dataLoc) {
auto field = GCTypeUtils::getField(dataLoc.type, dataLoc.index);
assert(field);
if (!field) {
// This is a bottom type; nothing will be written here.
assert(dataLoc.type.isBottom());
contents = PossibleContents::none();
return;
}

if (field->isPacked()) {
// We must handle packed fields carefully.
if (contents.isLiteral()) {
Expand Down
38 changes: 38 additions & 0 deletions test/lit/passes/gufa-refs.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6056,3 +6056,41 @@
)
)
)

(module
;; CHECK: (type $array (sub (array (mut i8))))
(type $array (sub (array (mut i8))))

;; CHECK: (type $1 (func))

;; CHECK: (global $global (ref null $array) (array.new_fixed $array 0))
(global $global (ref null $array) (array.new_fixed $array 0))

;; CHECK: (func $test (type $1)
;; CHECK-NEXT: (block ;; (replaces unreachable ArraySet we can't emit)
;; CHECK-NEXT: (drop
;; CHECK-NEXT: (ref.cast nullref
;; CHECK-NEXT: (global.get $global)
;; CHECK-NEXT: )
;; CHECK-NEXT: )
;; CHECK-NEXT: (drop
;; CHECK-NEXT: (i32.const 0)
;; CHECK-NEXT: )
;; CHECK-NEXT: (drop
;; CHECK-NEXT: (i32.const 0)
;; CHECK-NEXT: )
;; CHECK-NEXT: (unreachable)
;; CHECK-NEXT: )
;; CHECK-NEXT: )
(func $test
;; We should not error on sets to bottom types, even if they are cast from
;; valid values.
(array.set $array
(ref.cast nullref
(global.get $global)
)
(i32.const 0)
(i32.const 0)
)
)
)