Skip to content

[Parser] Do not eagerly lex strings #6543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tlively merged 2 commits into from
Apr 26, 2024
Merged

[Parser] Do not eagerly lex strings #6543

tlively merged 2 commits into from
Apr 26, 2024

Conversation

@tlively
Copy link
Member

@tlively tlively commented Apr 25, 2024

Lex them on demand instead to avoid wasted work.

@tlively tlively requested a review from kripken April 25, 2024 03:02
This was referenced Apr 25, 2024
Merged
Merged
@tlively Graphite App
Copy link
Member Author

tlively commented Apr 25, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tlively and the rest of your teammates on Graphite Graphite

This was referenced Apr 25, 2024
Merged
Merged
@tlively tlively force-pushed the parser-no-tok-string branch from 7c48a77 to 2cfb8a1 Compare April 26, 2024 00:03
@tlively tlively force-pushed the parser-no-tok-string branch from 2cfb8a1 to fb535c3 Compare April 26, 2024 01:34
@tlively Graphite App
Copy link
Member Author

tlively commented Apr 26, 2024 •
edited
Loading

Merge activity

  • Apr 25, 11:47 PM EDT: @tlively started a stack merge that includes this pull request via Graphite.
  • Apr 26, 12:51 AM EDT: Graphite rebased this pull request as part of a merge.
  • Apr 26, 1:22 AM EDT: @tlively merged this pull request with Graphite.

Base automatically changed from parser-no-tok-id to main April 26, 2024 04:50
@tlively tlively force-pushed the parser-no-tok-string branch from d6a6223 to 15d01ea Compare April 26, 2024 04:51
@tlively tlively merged commit df68786 into main Apr 26, 2024
@tlively tlively deleted the parser-no-tok-string branch April 26, 2024 05:22
@gkdn gkdn mentioned this pull request Aug 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kripken kripken kripken approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tlively @kripken