Skip to content

Fuzzer: Compare strings #6530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 2 commits into from
Apr 24, 2024
Merged

Fuzzer: Compare strings #6530

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d73be25
test
kripken Apr 24, 2024
0bc7649
yikes
kripken Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions src/tools/execution-results.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,17 +175,21 @@ struct ExecutionResults {
}

bool areEqual(Literal a, Literal b) {
if (a.type.isRef()) {
// Don't compare references. There are several issues here that we can't
// fully handle, see https://github.com/WebAssembly/binaryen/issues/3378,
// but the core issue is that since we optimize assuming a closed world,
// the types and structure of GC data can arbitrarily change after
// optimizations, even in ways that are externally visible from outside
// the module.
//
// TODO: Once we support optimizing under some form of open-world
// assumption, we should be able to check that the types and/or structure
// of GC data passed out of the module does not change.
// Don't compare references. There are several issues here that we can't
// fully handle, see https://github.com/WebAssembly/binaryen/issues/3378,
// but the core issue is that since we optimize assuming a closed world, the
// types and structure of GC data can arbitrarily change after
// optimizations, even in ways that are externally visible from outside
// the module.
//
// We can, however, compare strings as they refer to simple data that has a
// consistent representation (the same reasons as why we can print them in
// printValue(), above).
//
// TODO: Once we support optimizing under some form of open-world
// assumption, we should be able to check that the types and/or structure of
// GC data passed out of the module does not change.
if (a.type.isRef() && !a.type.isString()) {
return true;
}
if (a != b) {
Expand Down