[Strings] Add the string heaptype to core fuzzer places #6527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
commented
Apr 24, 2024
| IMPLIED_FEATURE_OPTS = { | ||
| '--disable-reference-types': ['--disable-gc'], | ||
| '--disable-reference-types': ['--disable-gc', '--disable-strings'], | ||
| '--disable-gc': ['--disable-strings'], |
Member
Author
There was a problem hiding this comment.
This may actually be needed on main now that the previous PR landed - should have perhaps been included there just to be safe. If this PR can't land quickly then I'll split it out.
tlively
approved these changes
Apr 24, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this we emit strings spontaneously (as opposed to just getting them from
initial contents).
The relevant
-ttftest has been tweaked slightly to show the impact of thischange: now there are some
string.new/constin the output.